Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.10 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Lusitaniae
Copy link

ns1-python v0.18.0 released in August
https://github.com/ns1/ns1-python/releases/tag/v0.18.0

Add usage stats pagination support
Drop support for EOL Python 3.6, add support for Python 3.7 to 3.10
TASK [create a record] ****************************************************************************************************************************************************************************************************************************************************************************************************************************
task path: /home/i/workspace/ns1_domains/example.yml:39
Monday 12 December 2022  19:15:25 +0700 (0:00:00.129)       0:00:07.067 ******* 
Using module file /home/i/workspace/modules/ns1.ns1/library/ns1_record.py
Pipelining is enabled.
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: i
<127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "<stdin>", line 102, in <module>
  File "<stdin>", line 94, in _ansiballz_main
  File "<stdin>", line 40, in invoke_module
  File "/usr/lib/python3.10/runpy.py", line 224, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py", line 511, in <module>
  File "/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py", line 506, in main
  File "/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py", line 495, in exec_module
  File "/home/i/.local/lib/python3.10/site-packages/ns1/zones.py", line 136, in add_X
    return record.create(callback=callback, errback=errback, **kwargs)
  File "/home/i/.local/lib/python3.10/site-packages/ns1/records.py", line 144, in create
    return self._rest.create(
  File "/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py", line 115, in create
    body = self._buildBody(zone, domain, type, **kwargs)
  File "/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py", line 101, in _buildBody
    body["answers"] = self._getAnswersForBody(kwargs["answers"])
  File "/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py", line 43, in _getAnswersForBody
    elif not isinstance(answers, collections.Iterable):
AttributeError: module 'collections' has no attribute 'Iterable'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 102, in <module>\n  File \"<stdin>\", line 94, in _ansiballz_main\n  File \"<stdin>\", line 40, in invoke_module\n  File \"/usr/lib/python3.10/runpy.py\", line 224, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py\", line 511, in <module>\n  File \"/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py\", line 506, in main\n  File \"/tmp/ansible_ns1_record_payload_tdeput1i/ansible_ns1_record_payload.zip/ansible/modules/ns1_record.py\", line 495, in exec_module\n  File \"/home/i/.local/lib/python3.10/site-packages/ns1/zones.py\", line 136, in add_X\n    return record.create(callback=callback, errback=errback, **kwargs)\n  File \"/home/i/.local/lib/python3.10/site-packages/ns1/records.py\", line 144, in create\n    return self._rest.create(\n  File \"/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py\", line 115, in create\n    body = self._buildBody(zone, domain, type, **kwargs)\n  File \"/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py\", line 101, in _buildBody\n    body[\"answers\"] = self._getAnswersForBody(kwargs[\"answers\"])\n  File \"/home/i/.local/lib/python3.10/site-packages/ns1/rest/records.py\", line 43, in _getAnswersForBody\n    elif not isinstance(answers, collections.Iterable):\nAttributeError: module 'collections' has no attribute 'Iterable'\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 1
}

After

TASK [create a record] ****************************************************************************************************************************************************************************************************************************************************************************************************************************
Monday 12 December 2022  19:22:01 +0700 (0:00:00.122)       0:00:07.214 ******* 
changed: [localhost] => {"changed": true, "data":  [redacted]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant