Call head() on the StatusResource pages only once per request.

The html <head> element contains duplicated content when there is other parameters to the requests because it is being called inside a for loop. It needs to be out of the loop. For example, see the duplicated meta refresh on this page : http://buildbot.net/metabuildbot/waterfall?branch=&builder=docs&reload=60
nsylvain · Jul 16, 2009 · 64773c1 · 64773c1
1 parent 18f19ae
commit 64773c1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/buildbot/status/web/base.py b/buildbot/status/web/base.py
@@ -338,7 +338,7 @@ def content(self, request):
         data += "<head>\n"
         for he in s.head_elements:
             data += " " + self.fillTemplate(he, request) + "\n"
-            data += self.head(request)
+        data += self.head(request)
         data += "</head>\n\n"
 
         data += '<body %s>\n' % " ".join(['%s="%s"' % (k,v)