Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed problematic system-* icons #4585

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Removed problematic system-* icons #4585

wants to merge 7 commits into from

Conversation

Foggalong
Copy link
Contributor

Fixes #3681

@Foggalong Foggalong added this to the 18.09.19 milestone Sep 19, 2018
@palob
Copy link
Member

palob commented Sep 19, 2018

Will have a look in 2 hours or so.

@Foggalong
Copy link
Contributor Author

I wasn't so sure on gnome-session-hibernate and gnome-session-suspend. Does anyone who uses GNOME know if those are used exclusively in launchers or are they action icons also?

@palob
Copy link
Member

palob commented Sep 19, 2018

AFAIK Ubuntu uses/used such launchers but I think the icons are named differently. I can't see them pop up in my GNOME. Since GNOME switched pretty much everything except for app icons to symbolic I can't think of a place where they would.
Even Adwaita doesn't contain any session-*.

Given that we've got mate-session-* icons in our theme maybe MATE, Xfce or Cinnamon do use this type of icons

@palob
Copy link
Member

palob commented Sep 19, 2018

Found the icons in the app directory of the Linux mint theme

Same for elementary-xfce.

@palob
Copy link
Member

palob commented Sep 19, 2018

No such app icons in the MATE theme https://github.com/mate-desktop/mate-icon-theme.

@palob
Copy link
Member

palob commented Sep 19, 2018

Xfce even got the removed ones :-( so we'll probably have to check some distros in real life.

@Foggalong
Copy link
Contributor Author

Damn, will asign this to next release so we can do some proper testing.

@Foggalong Foggalong modified the milestones: 18.09.19, 18.10.03 Sep 19, 2018
@Foggalong Foggalong modified the milestones: 18.10.03, 18.10.17 Oct 4, 2018
@bilelmoussaoui
Copy link
Contributor

Those icons should be removed and moved to Numix base theme as they are actions and not apps. That's where they are installed on the elementary theme (they follow the standards more than XFCE/Mate guys.)
Those GNOME icons are from GNOME2. They are not found here on my system (Fedora Rawhide with GNOME)

@Foggalong
Copy link
Contributor Author

@bilelmoussaoui It might be the case, but we do need to make sure removing them outright won't break things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants