ENH: Update NumPy logos #16767
ENH: Update NumPy logos #16767
Conversation
| @@ -1,4 +1,4 @@ | |||
| # <img alt="NumPy" src="https://cdn.rawgit.com/numpy/numpy/master/branding/icons/numpylogo.svg" height="60"> | |||
| # <img alt="NumPy" src="https://ghcdn.rawgit.org/numpy/numpy/master/branding/icons/logomark/numpylogoicon.svg" height="60"> | |||
|
|
|||
There was a problem hiding this comment.
This doesn't seem to be rendering properly, hit the ... button and choose View file. Maybe the image needs more height?
There was a problem hiding this comment.
I think there is a chicken-and-egg problem. The link is the post-PR place where the logo will be when the PR is merged. It currently lives in https://github.com/isabela-pf/numpy/blob/logorefresh/branding/icons/logomark/numpylogoicon.svg.
With that, the new logo is just the icon, where the old one was icon + text so I think we should add the text after it link is not to the primary logo, so it should be changed
Edit: rethink the link
There was a problem hiding this comment.
Hmm, that link is commented out, github seems to make its own link by default.
EDIT: which is probably why it is commented out.
There was a problem hiding this comment.
You can also see the effect of changes when editing the file and using preview.
There was a problem hiding this comment.
I think in markdown, a line that begins with a single # is rendered as <H1>.
There was a problem hiding this comment.
Apparently you can link directly to files in the repo: https://stackoverflow.com/questions/14494747/add-images-to-readme-md-on-github
There was a problem hiding this comment.
Lets put this in and worry about the link later.
There was a problem hiding this comment.
I think this will work, but we can try later. The images don't seem to be rendered in the preview.
# <img alt="NumPy" src="https://github.com/numpy/numpy/blob/master/branding/icons/logomark/numpylogoicon.svg?raw=true" height="60">
|
Thanks @isabela-pf |
|
Yep, the logo shows up on the front page after merge. |
|
An image with the text "NumPy" would probably be a better choice. |
|
Since it already contains the colors, can we add to this readme a record of the font that was used? |
|
@eric-wieser the text and logomark use a modified version of Lato Black. |
This updates NumPy logos to the refreshed versions as chosen in numpy.org # 37. I've included variations and guidelines as a reference for anyone looking to use the logo. I also updated the readme's logo with the appropriate file.