Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opencover #2029

Closed
wants to merge 12 commits into from
Closed

add opencover #2029

wants to merge 12 commits into from

Conversation

dicko2
Copy link
Contributor

@dicko2 dicko2 commented Feb 4, 2017

Creating pull request to test the build on travis and appveyor, this is not complete yet

Relates to #423

@dicko2
Copy link
Contributor Author

dicko2 commented Feb 4, 2017

Running open cover appears to have tripled the build time. Running on other projects I haven't seen such a large growth (10 to 30% increase max). I wonder if it's something to do with cake implementation possibly. I'll do some more testing tomorrow and see if I can pin it down.

@CharliePoole
Copy link
Contributor

Travis is failing due to a problem with log4net initialization.

There is a Cake extension for OpenCover.

Once you get this working happily, we should decide whether we want it to run all the time or only for certain builds.

@dicko2
Copy link
Contributor Author

dicko2 commented Feb 12, 2017

I'll have another look today, should be able to get it going i reckon.

Have a look at this https://github.com/integrations/codecov

They have a browser extension that allows you to review the code coverage on the pull request in GitHub. I think this is good as it allows the code coverage to easily be a part of the discussion around the code review.

Also you can fail build base on coverage of pull request, unlike traditional code coverage systems that measure cover by area or entire code base, its measured on the patch of the Pull Request

To take advantage of this we would need to have it running on the CI build. What do you think @CharliePoole ?

@dicko2
Copy link
Contributor Author

dicko2 commented Feb 13, 2017

I Recommend squashing on merge, commits are getting a bit messy from testing on appveyor. When we finally get there that is

@dicko2
Copy link
Contributor Author

dicko2 commented Apr 2, 2017

I cant get Cake Curl to not error on the Travis linux agents. I think its got something to do with the add-in support in cake. Error I am getting is about the NETstandard libraries, so i think we need a mono version of the addin in order to run it maybe?

The only other option i can see is s separate powershell script that only executes on appveyor, which is not elegant (would be nice to do it all in cake), but seems to be the only solution, so ill try this road.

@rprouse
Copy link
Member

rprouse commented Apr 3, 2017

Do you think updating Cake to the latest release would help? Or running with the --experimental flag?

@rprouse
Copy link
Member

rprouse commented Jul 24, 2017

@dicko2 I know tracking down build errors on the Travis builds is a pain, but are you going to pick this up again? It might be easier to test using the docker container support, see build-mono-docker.ps1

@rprouse
Copy link
Member

rprouse commented Aug 22, 2017

I am closing since we have not heard back from you. If you pick this up again, we will reopen.

@rprouse rprouse closed this Aug 22, 2017
@rprouse rprouse deleted the coverage-report branch May 14, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants