Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try push to github package server #4443

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Jul 28, 2023

Fixes #4440

@manfred-brands
Copy link
Member Author

@OsirisTerje The package was pushed:
image

I can see it here

I successfully managed to retrieve it as part of one of my projects.
However, I needed to authenticate with my github token in the nuget.config:

  <packageSourceCredentials>
    <NUnitGitHub>
      <add key="Username" value="PersonalAccessToken" />
      <add key="ClearTextPassword" value="ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" />
    </NUnitGitHub>
  </packageSourceCredentials>

Can you see an accessibility on the packages? Is it marked internal or public?

@manfred-brands
Copy link
Member Author

TODO: Update build.cake to remove BuildSystem.IsRunningOnAppVeyor section and get the version number from the github hash.

@OsirisTerje
Copy link
Member

Can you see an accessibility on the packages? Is it marked internal or public?

It is marked Private

@OsirisTerje
Copy link
Member

Also, we need to have the version number incrementing. It now seems to just pick the cake version number. Might be easier to add in gitversion perhaps

@manfred-brands
Copy link
Member Author

Can you see an accessibility on the packages? Is it marked internal or public?

It is marked Private

Can you change accessibility to public?

@OsirisTerje
Copy link
Member

I changed an org setting, allowing you to push a public package, it was off. I could not find any way of changing it after the push, so I guess you should push it again. Is there a visibility attribute in connection with the push ?

@manfred-brands
Copy link
Member Author

manfred-brands commented Aug 12, 2023

@OsirisTerje I added a git describe version number to the package:
image

Still working on github actions giving me a proper branch name. The "solutions" I found on the web don't seem to work.
However as we would only really make packages from master it should not be an issue.

I think it still shows private. Do you have a cog wheel that leads to something like the below (which is for my work account):

image

I see that NUnit3TestAdapter is not listed as private

@OsirisTerje
Copy link
Member

@manfred-brands I've changed the visibility to public for both NUnit and NUnitLite

@OsirisTerje
Copy link
Member

Btw, did you try to set up gitversion on to set the version number ?

@manfred-brands
Copy link
Member Author

Btw, did you try to set up gitversion on to set the version number ?

I used git describe based upon an annotated tag.

@MaceWindu
Copy link

Would be nice to see it running soon. It makes 4.0 testing more complex as myget dead and we need post-beta1 fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dev packages from myget to github packages
3 participants