WIP: Implement 4446 using {d} and {D} for derived class names. #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public override void AppendTextTo(StringBuilder sb, TestMethod testMethod, object?[]? args) | ||
| { | ||
| sb.Append(testMethod.TypeInfo!.Name); |
There was a problem hiding this comment.
I think the problem is that TypeInfo is set to be the methodInfo.TypeInfo. Need to find another way of accessing the correct data.
OsirisTerje
changed the title
|
Can someone allow the tests to be run in CI? I can't work out how to get the tests to run locally. |
|
Approved it for running now. But you should be able to run them locally by: build --target test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on #4446