New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing dev builds to myget.org #4631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds new minor version by default.
stevenaw
reviewed
Feb 19, 2024
stevenaw
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OsirisTerje
Looks good, no concerns on my end from a phone review.
I'll defer to you to merge in case you'd prefer a review from someone in a position to run it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a build action to publish to myget.
I set the prefix for dev builds to
alpha
to get the versioning to behave well. The suffix we had earlier usingdev
would be above a possiblebeta
.Further, I used the
MinVer
client to get a reasonable numbering scheme.This build triggers on main, master, release, and v3. I added the main now, because we have a task to move the master branch to main asap, I believe just after we have released 4.1 should be good.
We can then use a copy of this builddef for publishing to nuget.org, but just set it without any triggers, so we do it manually when we feel ready.
There are now packages built from this in https://www.myget.org/feed/nunit/package/nuget/NUnit and https://www.myget.org/feed/nunit/package/nuget/NUnitLite