In Scintilla based editors such as Notepad++, braille is now updated …

…correctly when moving the cursor using a braille display. Fixes #5678.
nvaccess · Mar 30, 2016 · f04b53e · f04b53e
1 parent 1684dc5
commit f04b53e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/source/NVDAObjects/window/scintilla.py b/source/NVDAObjects/window/scintilla.py
@@ -12,6 +12,7 @@
 from ..behaviors import EditableTextWithAutoSelectDetection
 import locale
 import watchdog
+import eventHandler
 
 #Window messages
 SCI_POSITIONFROMPOINT=2022
@@ -124,6 +125,9 @@ def _getCaretOffset(self):
 
 	def _setCaretOffset(self,offset):
 		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_GOTOPOS,offset,0)
+		# #5678: A caret event sometimes doesn't get fired when we do this,
+		# so fake one just in case.
+		eventHandler.executeEvent("caret", self.obj)
 
 	def _getSelectionOffsets(self):
 		start=watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_GETSELECTIONSTART,0,0)

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
@@ -16,6 +16,7 @@
 - In browse mode, when attempting to use single letter navigation to move to an element which isn't supported for the document, NVDA reports that this isn't supported rather than reporting that there is no element in that direction. (#5691)
 - When listing sheets in the Elements List in Microsoft Excel, sheets containing only charts are now included. (#5698)
 - NVDA no longer reports extraneous information when switching windows in a Java application with multiple windows such as IntelliJ or Android Studio. (#5732)
+- In Scintilla based editors such as Notepad++, braille is now updated correctly when moving the cursor using a braille display. (#5678)
 
 
 == Changes for Developers ==