Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAccessible NVDAObject: Use IAccessibleTable2/IAccessibleTableCell for row/col indexes/counts #6138

Closed
jcsteh opened this issue Jul 5, 2016 · 4 comments · Fixed by #7977
Closed

IAccessible NVDAObject: Use IAccessibleTable2/IAccessibleTableCell for row/col indexes/counts #6138

jcsteh opened this issue Jul 5, 2016 · 4 comments · Fixed by #7977
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@jcsteh
Copy link
Contributor

jcsteh commented Jul 5, 2016

The IAccessible NVDAObject currently uses IAccessibleTable to fetch row/column counts/indexes and IAccessibleTableCell for row/column headers. However, QT5 only supports IAccessibleTable2/Cell, not the older IAccessibleTable. It's reasonable to assume future implementations might do the same, though we still need to support IAccessibleTable for older implementations such as Symphony/OpenOffice/LibreOffice.

This will require additions to the table, tableID, rowCount, columnCount, rowNumber and columnNumber properties to use the new interfaces if they are available.

Note that we have an existing _IATableCell property to get that interface.
@LeonarddeR
Copy link
Collaborator

@michaelDCurran, I wish I had stumbled upon this before you started working on #7410. It is probably a bit too far-fetched to have this added into that pr as well?

@jcsteh
Copy link
Contributor Author

jcsteh commented Jul 18, 2017

This is out of scope for that PR, as it primarily deals with changes related to browse mode table navigation.

P3 because there is no specific demand for this yet.

@jcsteh jcsteh added the p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 18, 2017
@LeonarddeR
Copy link
Collaborator

LeonarddeR commented May 12, 2018 •
edited

@jcsteh /@michaelDCurran: It looks like this was implemented in #7977 and therefore can be closed. Or is there still something missing?

@michaelDCurran
Copy link
Member

Fixed in #7977

@michaelDCurran michaelDCurran mentioned this issue May 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support tables in Kindle for PC nvaccess/nvda
3 participants
@LeonarddeR @jcsteh @michaelDCurran