Support tables in Kindle for PC #7977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st tables) with comma and shift comma.
feerrenrut
reviewed
Feb 9, 2018
| @@ -63,6 +65,28 @@ def isAlive(self): | |||
| def __contains__(self,obj): | |||
| return obj==self.rootNVDAObject | |||
|
|
|||
| def _getTableCellAt(self,tableID,startPos,destRow,destCol): | |||
There was a problem hiding this comment.
Can you add a docstring for this? At a glance I don't understand why there is start and dest passed in, is this a range?
Perhaps its an override, and the docstring is on another class? Hard to know since this class inherits from a few classes.
There was a problem hiding this comment.
Please refer to the docstring on documentBase.DocumentWithTableNavigation._getTableCellAt.
|
@feerrenrut: I referred to the base class in the docstring for _getTableCellAt. I'm not sure if you completed review but I did incubate this early to ensure we get a good test period on Next. Your review is still required before Master. |
feerrenrut
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6138
Summary of the issue:
Amazon has recently been implementing accessibility support for tables within Kindle for PC. Therefore, once this is publically released, and there are books with table content available, ATs such as NVDA will be able to allow reporting of tables and table navigation within kfx books.
Description of how this pull request fixes the issue:
This PR adds support for tables within Kindle for PC.
Specifically:
Testing performed:
Navigated multiple books in various private builds of Kindle for PC. Table support should be publically available in their next release.
Navigated tables in Mozilla Firefox, to ensure IAccessibleTable2 works okay there as well. Note that NVDA will fall back to IAccessibleTable when IAccessibleTable2 is not available.
Known issues with pull request:
This PR depends on PR #7872 (support for reporting colspan and rowspan), but is not included directly in this PR.
Change log entry: