Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation system not used for emulated system keyboard keys in some cases #6212

Closed
LeonarddeR opened this issue Jul 27, 2016 · 0 comments · Fixed by #6267
Closed

Translation system not used for emulated system keyboard keys in some cases #6212

LeonarddeR opened this issue Jul 27, 2016 · 0 comments · Fixed by #6267
Milestone
2016.4

Comments

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Jul 27, 2016 •
edited

In the following cases, the untranslated, raw version of a keyboard key is passed to the end user rather than the translated version:

  1. When executing a gesture that emulates a system keyboard key in keyboard help. I already have a fix or this.
  2. When listing emulated system keyboard keys in the input gestures dialog.
LeonarddeR pushed a commit to BabbageCom/nvda that referenced this issue Aug 15, 2016
* In keyboard help for emulated system keyboard keys, the translated …
dac2b0c 
…version of a key is now spoken instead of the raw, untranslated version (nvaccess#6212)

* Also, the script name for emulated system keyboard keys is now localized

Both changes are based on a new simple function in keyLabels in which you insert a raw key combination string, which is than converted to a localised key combination identifier.
LeonarddeR pushed a commit to BabbageCom/nvda that referenced this issue Aug 16, 2016
* In keyboard help for emulated system keyboard keys, the translated …
c8fddef 
…version of a key is now spoken instead of the raw, untranslated version

* Also, the script name for emulated system keyboard keys is now localized

Both changes are based on a new simple function in keyLabels in which you insert a raw key combination string, which is than converted to a localised key combination identifier. (Re nvaccess#6212)
LeonarddeR pushed a commit to BabbageCom/nvda that referenced this issue Aug 16, 2016
* In keyboard help for emulated system keyboard keys, the translated …
4095142 
…version of a key is now spoken instead of the raw, untranslated version

* Also, the script name for emulated system keyboard keys is now localized

Both changes are based on a new simple function called getKeyCombinationLabel in keyLabels in which you insert a raw key combination string, which is than converted to a localised key combination identifier. (Re nvaccess#6212)
LeonarddeR pushed a commit to BabbageCom/nvda that referenced this issue Sep 8, 2016
In keyboard help for emulated system keyboard keys, the translated ve…
d6da5ac 
…rsion of a key is now spoken instead of the raw, untranslated version. Also, the script name for emulated system keyboard keys is now localized

Both changes are based on a new simple function called getKeyCombinationLabel in keyLabels in which you insert a raw key combination string, which is than converted to a localised key combination identifier. (Re nvaccess#6212)
@LeonarddeR LeonarddeR mentioned this issue Sep 28, 2016
Merged
jcsteh added a commit that referenced this issue Sep 28, 2016
@jcsteh
Incubates #6267. Re issue #6212.
0df1ff4
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 18, 2016
jcsteh pushed a commit that referenced this issue Oct 18, 2016
@LeonarddeR @jcsteh
Emulated system keyboard keys (e.g. a button on a braille display whi…
6ab85ec 
…ch emulates pressing the tab key) are now presented in the configured NVDA language in input help and the Input Gestures dialog. Previously, they were always presented in English. (#6212)

PR #6267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2016.4
Development

Successfully merging a pull request may close this issue.

Use translated key labels when identifying emulated system keyboard keys #6212 BabbageCom/nvda
2 participants
@LeonarddeR @nvaccessAuto