New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speech dictionary allows blank pattern (causes replacement to be read constantly) #6412
Comments
Just to clarify, we do need to allow blank replacements though. On 9/28/2016 11:52 PM, Quentin Christensen wrote:
Websites: email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu |
Sure, the problem here is definitely if you have no text in the pattern field but text in the replace field, it will add the replace text to everything NVDA says - I can't come up with any scenario where that would be useful? Possibly could also not save entries which have both fields blank? That doesn't cause anything extra to be said, not sure if there's any kind of (probably minor?) performance impact by it adding to everything that is uttered? |
Yeah, this is for sore a problem. On 9/28/2016 11:58 PM, Quentin Christensen wrote:
Websites: email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu |
P1 because this is quite problematic for users if they accidentally do it. |
A blank pattern in a dictionary entry causes issues see, #6412
The "pattern" field for a new dictionary entry is no longer allowed to be left blank. (Issue: #6412)
To replicate:
Recommended solution: Don't allow entry to be OK'd while pattern is blank and replacement is not.
The text was updated successfully, but these errors were encountered: