Fix crashes in 64 bit Mozilla and Chrome-based applications. #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gecko vbuf backend: Don't pass a pointer to a 32 bit int to IAccessible2::get_windowHandle, which expects a pointer to a 64 bit HWND. HWND is a 64 bit type on x64, but Windows guarantees that only 32 bits are used. However, just because the other bits aren't used doesn't mean they won't be written, thus potentially corrupting the stack. Crash originally reported by @MarcoZehe in Mozilla bug 1311062.
|
@michaelDCurran, can you take a look please? Ta. |
|
Looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gecko vbuf backend: Don't pass a pointer to a 32 bit int to IAccessible2::get_windowHandle, which expects a pointer to a 64 bit HWND.
HWND is a 64 bit type on x64, but Windows guarantees that only 32 bits are used. However, just because the other bits aren't used doesn't mean they won't be written, thus potentially corrupting the stack.
Crash originally reported by @MarcoZehe in Mozilla bug 1311062.