Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error loading Brailliant BI driver #6845

Closed
MichelSuch opened this issue Feb 4, 2017 · 22 comments · Fixed by #6854
Closed

Error loading Brailliant BI driver #6845

MichelSuch opened this issue Feb 4, 2017 · 22 comments · Fixed by #6854
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2017.2

Comments

@MichelSuch
Copy link
Contributor

A user reports me the following problem:
He tries to connect a Brailliant BI 40 display via bluetooth and gets the following error (part of log below).
This happens on his 2 machines:
Log:
INFO - braille.BrailleHandler.setDisplayByName (17:18:31):
Loaded braille display driver noBraille, current display has 0 cells.
ERROR - braille.BrailleHandler.setDisplayByName (17:18:33):
Error initializing display driver
Traceback (most recent call last):
File "braille.pyc", line 1259, in setDisplayByName
File "brailleDisplayDrivers\brailliantB.pyc", line 125, in init
File "hwIo.pyc", line 150, in init
File "serial\serialwin32.pyc", line 30, in init
File "serial\serialutil.pyc", line 260, in init
File "serial\serialwin32.pyc", line 56, in open
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe9 in position 23: ordinal not in range(128)
@dkager
Copy link
Collaborator

dkager commented Feb 5, 2017

It looks like the encoding error masks the actual error in serialwin32.py line 54:
if self.hComPort == win32.INVALID_HANDLE_VALUE:

@jcsteh
Copy link
Contributor

jcsteh commented Feb 5, 2017

@MichelSuch: Can you please enable hwIo debugging and provide a debug log as described in this article?

@dkager: It looks like this UnicodeDecodeError problem might be fixed in pyserial 2.7. We considered upgrading to that in #6068, but it turned out there was no benefit. I think this is a good enough reason to upgrade. :)

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 6, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Feb 6, 2017 via email

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 6, 2017 via email

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 6, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Feb 6, 2017

I'm definitely not seeing it in your log text. I'm guessing the log has been truncated, probably because it was too big to be included as a comment. Please try attaching the file via the web interface. Note that you'll probably need to rename it to have a .txt extension if you haven't already. Thanks.

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 6, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Feb 6, 2017 via email

@MichelSuch
Copy link
Contributor Author

nvda.log.zip
Ok, let's try with GitHub: here is the file

@jcsteh
Copy link
Contributor

jcsteh commented Feb 6, 2017

Thanks. Can you please have this person try this try build? Does this fix the problem? If not, please provide another debug log with this build.

@jcsteh jcsteh added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Feb 6, 2017
@MichelSuch
Copy link
Contributor Author

Hi,

Still does not work, here is the new log
nvda.log.zip

@jcsteh
Copy link
Contributor

jcsteh commented Feb 7, 2017

Sorry. I didn't account for something in that build, so it wouldn't have made any difference. Please try this build instead.

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 7, 2017 via email

@MichelSuch
Copy link
Contributor Author

Here is a new log, since the latest build works on his desktop but still fails on his laptop
nvda.log.zip

@dkager
Copy link
Collaborator

dkager commented Feb 7, 2017

Are you sure he upgraded? This looks like the same error to me.

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 7, 2017 via email

@MichelSuch
Copy link
Contributor Author

Hmmm,
He used the latest test version, but he did not sed me the good log file!
so here is the good one, sorry for inconvenience.
nvda.log.zip

@jcsteh
Copy link
Contributor

jcsteh commented Feb 8, 2017 via email

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Feb 8, 2017 via email

@jcsteh jcsteh mentioned this issue Feb 8, 2017
Merged
jcsteh added a commit that referenced this issue Mar 15, 2017
@jcsteh
Incubates #6854 (issue #6845): Update to pySerial 2.7.
0bb293f
@MichelSuch
Copy link
Contributor Author

Hi,
According to user's experience, this issue seems to be solved. So this ticket could be closed.

@jcsteh jcsteh reopened this Mar 20, 2017
@jcsteh
Copy link
Contributor

jcsteh commented Mar 20, 2017

It's fixed on next now, but it hasn't been merged to master yet. It's possible the problem has gone away for some users, but the potential still exists, so we should still merge this to master once it's done incubating on next.

@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Mar 29, 2017
jcsteh added a commit that referenced this issue Mar 29, 2017
@jcsteh
Update to pySerial 2.7. (PR #6854, issue #6845)
fe06e18 
This is needed to fix a UnicodeDecodeError in some languages when opening a serial port fails. This was preventing braille display drivers from trying further ports which might have worked.
pySerial is now included as its own git submodule, rather than as part of miscDeps. This necessitated adding its directory to the Python module search path in sourceEnv. Also, scons now sets the PYTHONPATH environment variable based on sourceEnv, rather than having the directories listed in two separate places.
jcsteh added a commit that referenced this issue Mar 29, 2017
@jcsteh
Update What's New for PR #6854 (issue #6845).
e12a71d
@dkager dkager mentioned this issue Sep 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2017.2
Development

Successfully merging a pull request may close this issue.

Update to pySerial 2.7. nvaccess/nvda
4 participants
@dkager @jcsteh @nvaccessAuto @MichelSuch