Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sugestion, provide a shortcut key and automatically advertise hortographic errors in google docs #8155

Open
fernando-jose-silva opened this issue Apr 9, 2018 · 9 comments

Comments

@fernando-jose-silva
Copy link

Steps to reproduce:

Open a document in google docs.
When navigating with arrows the nvda does not announce the hortographic errors.
There is not even a nvda shortcut key to navigate between the horizonal errors in the document, as there is in word (w).

Expected behavior:

The suggestion is that the nvda read the hortographic errors when navigating with the arrows through the text.
I would also like to suggest a shortcut key to allow you to navigate the horizons in a text.

Actual behavior:

Nvda does not currently advertise the hortographic errors when navigating the text with the arrows.
There is no shortcut key to allow quick movement between hortographic errors in text.

System configuration:

NVDA version:
all

NVDA Installed or portable:
instaled and portable

Other information:

Example: Running in a VM

Windows version:
all

Name and version of other software in use when reproducing the issue:

Other questions:

Does the issue still occur after restarting your PC?
yes

Have you tried any other versions of NVDA?

Please list them and the result

@ehollig
Copy link
Collaborator

ehollig commented Oct 5, 2018

@fernando-jose-silva what exactly do you mean when you say, "hortographic errors"? According to the shortcuts for Google Docs, you should be able to navigate to the next misspelling or previous misspelling by pressing Ctrl + ' or Ctrl + ;. I do not believe NVDA can create shortcuts for Google Docs.

@fernando-jose-silva
Copy link
Author

Many thanks for the feedback.
Is it possible to implement in nvda the ability to report the horological and grammatical errors reported by google docs when browsing line by line or word by word, functionality that we have in word.

@LeonarddeR
Copy link
Collaborator

What do you mean with horological errors?

NVDA should already be able to report grammar errors when appropriately exposed, see #8280

@fernando-jose-silva
Copy link
Author

I did some tests:
I opened a document in google docs and typed 4 lines of texts:
in the first line a text without errors.
In the second line a word with an error
on the third line a word without error.
in the fourth line a text with an error.
When walking line by line the nvda reads the text and is not announced in a moment the error.
When navigating with right or left arrows navigating by characters, or by navigating with ctrl + right arrow or ctrl + left arrow word by word the nvda announces inside hortographic error and out of hortographic error.
The suggestion would be that when browsing line by line the misspelling was also announced, just as in word.
Also when typing a word with hortographic error and pressing space in the docs nothing is heard, and in word the sound of hortographic error is spoken.
The suggestion is to translate the same word experience into the docs by typing misspelled words and pressing space if you hear the sound of hortographic error.
My suggestion is for grammatical errors and hortographic errors.
I do not speak English and the text is translated by google.

@LeonarddeR
Copy link
Collaborator

I think I understand you now and I've been able to reproduce this. Google uses its own implementation to announce spelling errors, it does not expose spelling and grammar errors in a way that NVDA can detect them as such. Therefore, there's probably nothing we can do here.

@derekriemer: Could you spread any light on this?

@frastlin
Copy link

I request this feature every day I use Google docs.
This, jumping by headings, and editing tables, are still not the best experience for me in Google Docs.

@Adriani90
Copy link
Collaborator

maybe @aleventhal or @ObjectInSpace can help here, NVDA should be able to identify these if they are properly exposed I guess.

@ObjectInSpace
Copy link

ObjectInSpace commented Dec 8, 2020

I'm happy to pass this on, but I'm a little confused about the precise ask. I was under the impression that spelling and grammatical errors are currently announced by NVDA, if braille mode is turned on from the accessibility settings dialog in docs's tools menu. This places the document within a content editable. Chrome and Firefox report text mistakes in content editables and text input fields, so this should also hold true for docs when it is in this mode. Is this not the case?

note that when braille mode is off, screenreaders receive updates from docs via live regions. I don't believe they can contain this type of formatting information.

Is there a third type of error that is not being reported to screenreaders? A reproduction case could clarify the matter.

Thanks much!

@Adriani90
Copy link
Collaborator

Ok this works properly in Firefox but not completely in Chrome. When enabling braille support, in Chrome, NVDA reports spelling and gramar errors when navigating through the document, but it does not report them when you type via sound or something like it does in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants