Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxPython 4: wx.TextEntryDialog no longer accepts defaultValue kwarg #8523

Closed
josephsl opened this issue Jul 19, 2018 · 0 comments · Fixed by #8524
Closed

wxPython 4: wx.TextEntryDialog no longer accepts defaultValue kwarg #8523

josephsl opened this issue Jul 19, 2018 · 0 comments · Fixed by #8524
Milestone
2018.3

Comments

@josephsl
Copy link
Collaborator

Hi,
Regression found with #7077: wx.TextEntryDialog no longer supports defaultValue kwarg, seen when trying to edit comments in Excel and rename config profiles.

Steps to reproduce:

  1. Open Excel.
  2. Move to a cell and press Shift+F2 to edit comment.

Actual behavior:

Error tone is heard or NVDA appears to do nothing.

Expected behavior:

Text entry dialog shows up.

System configuration:

NVDA Installed/portable/running from source:

Installed

NVDA version:

Alpha.15608

Windows version:

Windows 10 Version 1803

Name and version of other software in use when reproducing the issue:

Microsoft Office 365 Excel version 16.0.10228.20134

Other information about your system:

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes (2018.2.1, 2018.3 beta)

Traceback:

ERROR - scriptHandler.executeScript (07:51:44.562):
error executing script: <bound method ExcelCell.script_editComment of <NVDAObjects.window.excel.ExcelCell object at 0x051E4EF0>> with gesture u'shift+f2'
Traceback (most recent call last):
File "scriptHandler.pyc", line 187, in executeScript
File "NVDAObjects\window\excel.pyc", line 1407, in script_editComment
TypeError: TextEntryDialog(): arguments did not match any overloaded call:

Thanks.
josephsl added a commit to josephsl/nvda that referenced this issue Jul 19, 2018
@josephsl
wxPython 4/TextEntryDialog: use 'value' instead of 'defaultValue'. Re n…
4f68b13 
…vaccess#8523.

Regression: wx.TextEntryDialog no longer accepts defaultValue kwarg, replaced by just 'value'. This affected edit command dialog in Excel and rename function in config profiles dialog (Control+NVDA+P).
@josephsl josephsl mentioned this issue Jul 19, 2018
Merged
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 19, 2018
michaelDCurran pushed a commit that referenced this issue Jul 19, 2018
@josephsl @michaelDCurran
wxPython 4/deprecated items: use TextEntryDialog.Value, use Menu.Inse…
6c04bfb 
…rt/Menu.Remove (#8524)

* wxPython 4/TextEntryDialog: use 'value' instead of 'defaultValue'. Re #8523.

Regression: wx.TextEntryDialog no longer accepts defaultValue kwarg, replaced by just 'value'. This affected edit command dialog in Excel and rename function in config profiles dialog (Control+NVDA+P).

* wxPython 4/Menu: user Menu.Insert and Menu.Remove instead of deprecated Menu.InsertItem and Menu.RemoveItem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2018.3
Development

Successfully merging a pull request may close this issue.

wxPython 4/deprecated items: use TextEntryDialog.Value, use Menu.Insert/Menu.Remove josephsl/nvda
2 participants
@josephsl @nvaccessAuto