Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging during text paragraph navigation in UIA edge #16450

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

mltony
Copy link
Contributor

@mltony mltony commented Apr 25, 2024

Link to issue number:

Closes #16436.

Summary of the issue:

Text paragraph navigation hangs in UIA edge near the end of document.

Description of user facing changes

N/A

Description of development approach

Replaced logic to find next paragraph with already polished function from another PR. It's got a condition that prevents hanging in this case.

Testing strategy:

Tested manually on provided test case.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review April 25, 2024 17:20
@mltony mltony requested a review from a team as a code owner April 25, 2024 17:20
@mltony mltony requested a review from seanbudd April 25, 2024 17:20
@seanbudd seanbudd changed the base branch from master to beta April 30, 2024 00:09
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 30, 2024
@seanbudd seanbudd added this to the 2024.2 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. queued for merge
Projects
None yet
2 participants