hwIo.Serial: Add port attribute to fix rare exception in brailliantB braille display driver #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…braille display driver. serial.Serial has a port attribute and a log message in the brailliantB driver relied on this. hwIo.Serial should have this attribute as well. Originally reported here: #6035 (comment)
|
@michaelDCurran, can you please review? I'd like to get this into 2016.3 if possible. Thanks. |
|
CC @dkager. |
|
Fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serial.Serial has a port attribute and a log message in the brailliantB driver relied on this. hwIo.Serial should have this attribute as well.
Originally reported here: #6035 (comment)
This doesn't need a What's New entry because the exception in the brailliantB driver wouldn't have propagated enough to cause any actual problem. However, it's still ugly at best.