Excel: A sound is played when typing into protected cells rather than speaking typed characters #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen typing into protected cells.
|
@feerrenrut: review please. |
feerrenrut
reviewed
Nov 17, 2016
| @@ -1155,6 +1156,15 @@ def _get_states(self): | |||
| states.add(controlTypes.STATE_UNLOCKED) | |||
| return states | |||
|
|
|||
| def event_typedCharacter(self,ch): | |||
| # # 6570: You cannot type into protected cells. | |||
| # A part from speaking characters being miss-leading, Office 2016 protected view doubles characters as well. | |||
There was a problem hiding this comment.
minor: "Apart" rather than "A part"
| @@ -1155,6 +1156,15 @@ def _get_states(self): | |||
| states.add(controlTypes.STATE_UNLOCKED) | |||
| return states | |||
|
|
|||
| def event_typedCharacter(self,ch): | |||
| # # 6570: You cannot type into protected cells. | |||
There was a problem hiding this comment.
minor: there is a space between the hash symbol and the issue number.
| # # 6570: You cannot type into protected cells. | ||
| # A part from speaking characters being miss-leading, Office 2016 protected view doubles characters as well. | ||
| # Therefore for any non-control char on protected cells, play the default sound rather than speaking the character | ||
| if ord(ch)>26 and controlTypes.STATE_UNLOCKED not in self.states and controlTypes.STATE_PROTECTED in self.parent.states: |
There was a problem hiding this comment.
It would be helpful if 26 was a named value. Is it the first printable character code?
|
How about this @feerrenrut? I addressed the comment issues, but I changed the numeric value into a space. I can add a constant if you think it is really necessary... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6570