Support for Microsoft Edge from Windows build 15002 and up #6789
Conversation
… windows, as Edge, and soon to be all UWP apps, will no longer have their windows as a descendant of the foreground window.
…is not marked as being in a framework of MicrosoftEdge, rather than only seeing if the document is inside an EdgeRootContainer. This change is necessary for Windows builds 15002 and up where the root container is now gone.
|
it is possible that the container change will be fixed by Microsoft before RS2. However the foreground descendant change is deliberate going forward. |
|
Hello. on some sites such as YouTube NVDA does not see nvda next-13843,f979ca07 |
…nts for UWP apps by also ensuring the window is equal to or a descendant of the active window in the current input thread.
|
@jcsteh: it will be difficult to check for microsoftedgecp in shouldAcceptEvent as we need to some how get an appmodule from a windowhandle. However, for now instead I have tightened up the check for Windows.UI.Core in general, by also checking that the window is equal to or a descendant of the active window in the current input thread. This works nicely for Edge. |
source/eventHandler.py
Outdated
| # #6713: Edge (and soon all UWP apps) will no longer have windows as descendants of the foreground window. | ||
| # However, it does look like they are always equal to or descendants of the "active" window of the input thread. | ||
| gi=winUser.getGUIThreadInfo(0) | ||
| if winUser.isDescendantWindow(gi.hwndActive,windowHandle) and wClass.startswith('Windows.UI.Core'): | ||
| return True |
There was a problem hiding this comment.
We don't need GUIThreadInfo outside this yet, so I think I'd prefer this inside the condition:
if wClass.startswith('Windows.UI.Core'):
return isDescendant blahblah
|
We're going to incubate this just for a few days and then merge to master early. We really want this in 2017.1 and it's thus important that it gets wider beta testing. |
|
Let us know when you want testing with Edge to begin. I’ve been keeping my hands off edge and NVDA.
|
… with fields due to a collapsed range due to the range from an enclosing element ending on or before this range. Quite common in Edge builds once the 'gap' is removed.
|
@jcsteh: Along with the fix you requested in the last review, I also fixed the one and only issue that occurs when this code is run with the Edge 'gap' removed: namely an endless recursion in Edge's _getTextwithFieldsFromUIARange. Commit 1b20ccd is a tiny change that just checks for a collapsed range and if so returns, and probably should have always been there anyway. You should review it, however I took the choice of merging it to Next along with the other change as time is quickly running out. |
|
Hello. When you switch keyboard layouts in microsoft edge nvda continues to refer to the symbols on the keyboard recruited which was originally. helps you switch between Windows. |
|
Here's what the error I see when viewing the log. |
|
Hi, covered by #6712, please post your comments there. Thanks.
From: nikita [mailto:notifications@github.com]
Sent: Tuesday, February 7, 2017 8:22 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Support for Microsoft Edge from Windows build 15002 and up (#6789)
Here's what the error I see when viewing the log.
nvda.txt <https://github.com/nvaccess/nvda/files/759711/nvda.txt>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#6789 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEoZmzVtIp3F1MnTYimPOXNpDCwxks5raUMFgaJpZM4Lr3Z7> .
|
Handle the change to the Edge document container UIAElement, and explicitly allow events for Windows.UI.Core windows as foreground checks will no longer work for UWP.
Fixes #6713