Support automatic language switching in Microsoft Edge and other UI Automation text implementations #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omation (including Microsoft Edge).
…ale identifiers to locale names. This has been manually calculated from locale.windows_locale. Oddly windows_locale does not contain them directly. Both UI Automation and ITextDocument may expose these primary language locale identifiers if country specific information is not available. For example, the html <p lang="de"> exposes LCID 0x7 (German) as opposed to <p lang="de-DE"> which exposes 0x407 (German, Germany).
feerrenrut
approved these changes
Feb 8, 2017
source/NVDAObjects/UIA/__init__.py
Outdated
| @@ -135,6 +136,13 @@ def _getFormatFieldAtRange(self,range,formatConfig,ignoreMixedValues=False): | |||
| annotationTypes=getUIATextAttributeValueFromRange(range,UIAHandler.UIA_AnnotationTypesAttributeId,ignoreMixedValues=ignoreMixedValues) | |||
| if annotationTypes==UIAHandler.AnnotationType_SpellingError: | |||
| formatField["invalid-spelling"]=True | |||
| val=getUIATextAttributeValueFromRange(range,UIAHandler.UIA_CultureAttributeId,ignoreMixedValues=ignoreMixedValues) | |||
There was a problem hiding this comment.
I think val could have a better name. Perhaps cultureCodeVal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part from exposing language information from UI Automation text formatting, this PR also supports mappings of all Windows primary language locale identifiers to locale names. This has been manually calculated from locale.windows_locale. Oddly windows_locale does not contain them directly.
For example, the html
exposes LCID 0x7 (German) as opposed to
which exposes 0x407 (German, Germany).
This also should provide a more complete fix for #6611 as that was caused due to values such as 0x09 (English) missing from the mapping.
Fixes #6852