Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARIA table attributes, skip layout tables, and don't get stuck on hidden cells #7410

Merged
merged 4 commits into from Aug 2, 2017

Commits on Jul 15, 2017

  1. Add support for ARIA rowindex, colindex, rowcount and colcount in Gec…

    …ko / Chrome for both browse mode and focus mode.
    
    Specifically:
    * IAccessible NVDAObject properties: rowNumber, columnNumber, rowCount and columnCount now expose the ARIA values if available, otherwise falling back to the original physical table information.
    * Gecko controlField attributes: table-rownumber, table-columnnumber, table-rowcount and table-columncount now expose the ARIA values if available, otherwising falling back to the original physical table information
    *  New Gecko controlField attributes: table-physicalrownumber, table-physicalcolumnnumber, table-physicalrowcount and table-physicalcolumncount values always expose the physical table information no matter what the presentational values may be.
    * Added new class variables to BrowseModeDocumentTreeInterceptor: navigationalTableRowNumberAttributeName and navigationalTableColumnNumberAttributeName which are used by BrowseModeDocumentTreeInterceptor._getTableCellCoords in place of  the literal strings "table-rownumber" and "table-columnnumber" respectively, to allow fetching of the correct attributes containing physical table information.
    * Gecko_ia2 VirtualBuffer: override navigationalTableRowNumberAttributeName and navigationalTableColumnNumberAttributeName To provide the use of table-physicalrownumber and table-physicalcolumnnumber.
    michaelDCurran committed Jul 15, 2017
    Copy the full SHA
    4cc163c View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2017

  1. Copy the full SHA
    1d4519c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. Gecko browseMode: skip over hidden table cells in table navigation co…

    …mmands. MSHTML already did this.
    michaelDCurran committed Jul 17, 2017
    Copy the full SHA
    e43a671 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. Address review actions:

    * In the gecko vbufBackend: comment why two sets of table attributes are being added.
    * browseModeDocumentTreeInterceptor._getNearestTableCell: make the retry limit configurable via a _missingTableCellSearchLimit property.
    * browseModeDocumentTreeInterceptor._getNearestTableCell: try more cells for any LookupError not just hiddenTableCellFound (browsers such as chrome do not expose hidden cells).
    * remove browseMode.HiddenTableCellFound
    * Gecko_ia2 virtualBuffer's _getTableCellAt: raise LookupError if a hidden cell is found rather than HiddenTableCellFound
    michaelDCurran committed Jul 19, 2017
    Copy the full SHA
    a2b10a0 View commit details
    Browse the repository at this point in the history