Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disable table navigation commands for layout tables if the user has explicitly chosen to have layout tables reported. #7464

Merged
merged 6 commits into from Aug 2, 2017
Merged

Don't disable table navigation commands for layout tables if the user has explicitly chosen to have layout tables reported. #7464

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4cc163c
Add support for ARIA rowindex, colindex, rowcount and colcount in Gec…
michaelDCurran Jul 15, 2017
1d4519c
No longer include layout tables in table navigation commands
michaelDCurran Jul 16, 2017
e43a671
Gecko browseMode: skip over hidden table cells in table navigation co…
michaelDCurran Jul 17, 2017
a2b10a0
Address review actions:
michaelDCurran Jul 19, 2017
f8ba66f
Merge branch 'master' into ariaGrids
michaelDCurran Aug 2, 2017
99ef8a8
Still enable table navigation for layout tables if the user has confi…
michaelDCurran Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions source/browseMode.py
View file
Open in desktop
Expand Up @@ -1557,13 +1557,14 @@ def _getTableCellCoords(self, info):
info = info.copy()
info.expand(textInfos.UNIT_CHARACTER)
fields=list(info.getTextWithFields())
# First record the ID of all layout tables so that we can skip them when searching for the deepest table
# If layout tables should not be reported, we should First record the ID of all layout tables so that we can skip them when searching for the deepest table
layoutIDs=set()
for field in fields:
if isinstance(field, textInfos.FieldCommand) and field.command == "controlStart" and field.field.get('table-layout'):
tableID=field.field.get('table-id')
if tableID is not None:
layoutIDs.add(tableID)
if not config.conf["documentFormatting"]["includeLayoutTables"]:
for field in fields:
if isinstance(field, textInfos.FieldCommand) and field.command == "controlStart" and field.field.get('table-layout'):
tableID=field.field.get('table-id')
if tableID is not None:
layoutIDs.add(tableID)
for field in reversed(fields):
if not (isinstance(field, textInfos.FieldCommand) and field.command == "controlStart"):
# Not a control field.
Expand Down