Add the ability to automatically tether to focus or review #7489

LeonarddeR · 2017-08-11T13:45:37Z

Link to issue number:

Summary of the issue:

Currently, using the review cursor requires one to explicitly tether to review and back. See also #2385 (comment)

Description of how this pull request fixes the issue:

This adds the ability to the GUI to enable auto tethering. If set, NVDA will automatically tether to review for review cursor changes, and tethers back to focus when changing the focus or caret.

The following implementation is used, based on the proposal in #2385 (comment)

Ad a new boolean option to the config spec, autoTether
Replace the getter and setter for braille.BrailleHandler.tether with getTether and setTether methods. This is because setTether needs an additional keyword argument to determine whether it was an automatic or manual tether action. Of course, keep the old tether auto property for backwards compatibility, but deprecate it
Always show ui.reviewMessage in braille when auto tethering is on
Tether to review for several scripts in globalCommands, namely:
- reviewMode_next
- reviewMode_previous
- review_currentLine
- review_currentWord
- review_currentCharacter
Add a new shouldAutoTether keyword argument to BrailleHandler.handleGainFocus, handleCaretMove and handleReviewMove. This argument should default to True, and can be set to False in places in the code base where this is explicitly required. Of course, shouldAutoTether should be ignored if the auto tethering option is disabled globally.

After some discussion with @dkager, we decided that using the several previous/next scripts to do auto tethering is ugly. Thus, to keep things in sync nicely, auto tethering is done by handleReviewMove instead. This has the following implications:

A. handleReviewMove should not auto tether when the move is caused due to the review cursor following the focus or the caret. Since most of the review following focus is done using api.setNavigatorObject with the isFocus parameter set to True, api.setNavigatorObject should somehow communicate this to handleReviewMove. However, setNavigatorObject doesn't execute handleReviewMove itself, but executes the becomeNavigatorObject event, which executes handleReviewMove. The isFocus parameter gets lost in this process. This is fixed by creating a caching variable, eventHandler.lastReviewMoveDueToFollowing. This new variable is also set properly by api.setReviewPosition based on a new parameter isCaret. At least for setNavigatorObject, I'd rather pass this info as an event parameter, but that means we break backwards compatibility.
B. There have been some edge cases that needed to be changed in setting the navigatorObject. For example, in the explorer appmodule on the SuggestionListItem class, the navigator object is set for event_UIA_elementSelected. This call of setNavigatorObject now has the extra isFocus parameter set to True.

Testing performed:

Various internal testing, but this needs to be tested more broadly. I'd like to request an initial review first, though.

Known issues with pull request:

None I'm currently aware of, except for the implications as noted above. And, no unit tests, as I really have no idea how to do this reliably.

Changelog entry

Changes
- It is no longer necessary to explicitly tether braille to focus or review, as this will happen automatically by default. (Automatically switch braille tethering between review and focus #2385)
  - Note that automatic tethering to review will only occur when using a review cursor or object navigation command. Scrolling will not activate this new behavior.

… conflicts

dkager

Assuming it actually works (haven't tested this myself) I think it looks quite good. Just one or two small points.

dkager · 2017-10-13T19:16:52Z

source/NVDAObjects/__init__.py

@@ -961,7 +961,7 @@ def event_foreground(self):
 	def event_becomeNavigatorObject(self):
 		"""Called when this object becomes the navigator object.
 		"""
-		braille.handler.handleReviewMove()
+		braille.handler.handleReviewMove(shouldAutoTether=not eventHandler.lastReviewMoveDueToFollowing)


This variable name isn't very clear if you don't have the surrounding context of this PR. Maybe choose another name?

dkager · 2017-10-13T19:18:07Z

source/api.py

@@ -177,13 +177,14 @@ def getReviewPosition():
 		globalVars.reviewPosition,globalVars.reviewPositionObj=review.getPositionForCurrentMode(obj)
 		return globalVars.reviewPosition

-def setReviewPosition(reviewPosition,clearNavigatorObject=True):
+def setReviewPosition(reviewPosition,clearNavigatorObject=True, isCaret=False):


Comma police. :) Also, the docstring needs updating.

dkager · 2017-10-13T19:19:38Z

source/api.py

 	"""Sets a TextInfo instance as the review position. if clearNavigatorObject is true, It sets the current navigator object to None so that the next time the navigator object is asked for it fetches it from the review position.
 	"""
 	globalVars.reviewPosition=reviewPosition.copy()
 	globalVars.reviewPositionObj=reviewPosition.obj
 	if clearNavigatorObject: globalVars.navigatorObject=None
-	braille.handler.handleReviewMove()
+	eventHandler.lastReviewMoveDueToFollowing = isCaret


Can we be sure that this line and the one below it are only ever executed in one thread at a time?

dkager · 2017-10-13T19:21:32Z

source/braille.py

@@ -28,6 +28,7 @@
 from collections import namedtuple
 import re
 import scriptHandler
+import eventHandler


Not too happy with another circular dependency, but I know we discussed this before and all solutions we came up with were hacky.

dkager · 2017-10-13T19:25:26Z

source/braille.py

 			return
 		reviewPos = api.getReviewPosition()
+		#if reviewPos.obj == api.getFocusObject() and config.conf["reviewCursor"]["followFocus"]:


I would say just remove these two lines.

dkager · 2017-10-13T19:26:14Z

source/config/configSpec.py

@@ -61,6 +61,7 @@
 	noMessageTimeout = boolean(default=false)
 	messageTimeout = integer(default=4,min=0,max=20)
 	tetherTo = string(default="focus")
+	autoTether= boolean(default=false)


…ng event handlers, to support executing events with undefined kwargs.

… tethered to review before

michaelDCurran

I feel that auto tethering is really what we would want the majority NVDA user to be using, Therefore we should set autoTether to True by default.
But something is bothering me a little with this particular option as a checkbox. What happens if it is on, but tetherTo is set to review?
I assume autoTether in this case pretty much has no meaning?

michaelDCurran · 2017-11-23T06:16:52Z

source/eventHandler.py

+		try:
+			return func(*args, **self.kwargs)
+		except TypeError:
+			return extensionPoints.callWithSupportedKwargs(func, *args, **self.kwargs)


Please log a clear message here (perhaps warning) so that we catch these issues pretty quick and fix them.

michaelDCurran · 2017-11-23T06:20:48Z

source/sayAllHandler.py

@@ -151,7 +151,7 @@ def readTextHelper_generator(cursor):
 					if cursor==CURSOR_CARET:
 						updater.updateCaret()
 					if cursor!=CURSOR_CARET or config.conf["reviewCursor"]["followCaret"]:
-						api.setReviewPosition(updater)
+						api.setReviewPosition(updater, isCaret=True)


Should perhaps isCaret be only true if cursor==CURSOR_CARET?

michaelDCurran · 2017-11-23T06:34:49Z

source/appModules/lockapp.py


 	def event_appModule_loseFocus(self):
 		if not config.conf["reviewCursor"]["followFocus"]:
-			api.setReviewPosition(self._oldReviewPos)
+			api.setReviewPosition(self._oldReviewPos, isCaret=False)


As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject.

LeonarddeR · 2017-11-23T13:50:21Z

But something is bothering me a little with this particular option as a checkbox. What happens if it is on, but tetherTo is set to review?
I assume autoTether in this case pretty much has no meaning?

It still has a meaning. When tethering is set to review and auto tethering is on, the initial tethering mode is review until auto tethering triggers focus. However, I agree that this is confusing.

@dkager, @bramd, @jcsteh: thoughts? I'd suggest having three options, focus, review and auto. I recall from one of our braille discussions that @jcsteh preferred separate options for tethering mode focus/review and auto tethering on/off, because it allows you to quickly override the decision made by auto tethering. I belief that's the reason I implemented it as it is now. However, after thought about it a little more, I think i agree with Mick that it is a bit confusing from an UX perspective.

michaelDCurran · 2017-11-23T22:00:12Z

As you have explained that autoTether works both ways, I'm now more comfortable with the checkbox. However, I would suggest that: 1. If the checkbox is checked, perhaps we could disable the combobox as it has no meaning. 2. It would be nice to perhaps have the tether script toggle between focus, review and auto... either that or have a separate script binding, though I think this is a bit overkill.

josephsl · 2017-11-23T22:06:16Z

Hi, I’m thinking a single script will be sufficient, similar to what we have for progress bar output and indentation tones. Thanks. From: Michael Curran [mailto:notifications@github.com] Sent: Thursday, November 23, 2017 2:00 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [nvaccess/nvda] Add the ability to automatically tether to focus or review (#7489) As you have explained that autoTether works both ways, I'm now more comfortable with the checkbox. However, I would suggest that: 1. If the checkbox is checked, perhaps we could disable the combobox as it has no meaning. 2. It would be nice to perhaps have the tether script toggle between focus, review and auto... either that or have a separate script binding, though I think this is a bit overkill. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7489 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkO_nXXARaKf3FBKeBtgZXXjJtH-Yks5s5erugaJpZM4O0rNh> .

jcsteh · 2017-11-23T22:20:42Z

Another way of handling this is to: 1. Have three options in the GUI (focus, review and auto). 2. When auto is enabled, the tether command should just temporarily override the decision chosen by auto (which, based on your comments, is what happens now). I'm not sure it makes sense to have auto as an option for the command, though. Auto never really stops being the case; the command just temporarily overrides it until the next switch. So, if auto switched to focus and you overrode it to review, it's still really in auto mode, so having an auto option is misleading. Perhaps we need to somehow indicate that the tether is temporary in auto mode. "Braille temporarily tethered to review" would do this, but it's ridiculously verbose.

michaelDCurran · 2017-11-23T22:31:18Z

I wonder if there really is much of a use case at all for temporarily switching with the tether command while auto is enabled? In the case of say reviewing a dos console window while typing, and review follows caret is off, this becomes impossible because the caret will still keep forcing tether to focus... I think.

jcsteh · 2017-11-23T22:40:14Z

Urg. You're right, but that's definitely a use case we need to think about, since I'd say it's actually fairly common. If temporarily tethered to review, I wonder if it makes sense to only tether to focus if the focus moves, not the caret.

michaelDCurran · 2017-11-24T01:36:13Z

Having spoken to Jamie directly, we both agree that the GUI should just be a combo box of auto, focus and review. We discussed the config also reflecting this in that it is a key with one of 3 values, though this would involve an upgrade step to force previous configs from focus to auto. I think for this reason, and due to the following number 2 point, it should remain as two separate config keys as it is right now. There are a few options for the tether command script: 1. Have it toggle between auto, focus and review. This is my personal choice. 2. Leave it as is. I.e. toggles between focus and review When auto is off, and temporarily between focus and review when auto is on, allowing braille scrolling to control both review or caret, but it to snap back when something else occurs. In future we may want to think about something specific for review in consoles, as these seem to be a special case where the user is forced to use the review cursor because the caret is unable to move due to scrolling etc. Other peoples' thoughts?

LeonarddeR · 2017-11-24T10:50:03Z

@michaelDCurran commented on 24 nov. 2017 02:36 CET:

There are a few options for the tether command script:

Have it toggle between auto, focus and review. This is my personal
choice.

I agree.

Leave it as is. I.e. toggles between focus and review When auto is
off, and temporarily between focus and review when auto is on, allowing
braille scrolling to control both review or caret, but it to snap back
when something else occurs.

This will probably be confusing for the end user.

I'm intending to set the tetherTo config parameter to focus when the autoTether config parameter is True. We can also use the last state of tetherTo before enabling autoTether, but that will result into undefined behavior.

bramd · 2017-11-24T23:24:32Z

Hmm, I haven't tested this yet, but making a toggle with three options seems the clearest interface to me as well.

Some other thoughts:

Given the use case that you want to read some text in a document or in a console and type at another location in the document or console, it's also needed to disable following of the caret by the review cursor. I know it is a lot of magic, but somehow having a toggle between auto/focus/review, it would make sense to turn review mode in a real review mode without being disturbed by caret/focus changes.

michaelDCurran · 2017-12-04T05:37:19Z

This will need an update to the user guide for the tether setting. But looks good other than that.

…n reviewing a terminal

…would result in the caret not being followed correctly. This also applies to the braille_toFocus script

LeonarddeR · 2017-12-07T05:05:49Z

I just pushed another commit that fixes #5237, tethering from review back to focus failed in browse mode. Also, the braille_toFocus script is now working much more reliably in auto tethering cases.

@derekriemer reported issues with tethering on Gitter, but I can't reproduce them. Note that when using object review, it might look like you are tethered to focus even though you are tethered to review. You can check this by setting focus context representation to "always fill display" which gives you a more clear view of difference between focus and review tethering.

@michaelDCurran: To be specific, there are now 3 new commits since your last review I belief.

aaclause · 2017-12-08T07:52:34Z

I have a strange behavior since this function is implemented. To reproduce it, the simplest is:

Open 2 instances of cmd;
Enable "braille tether to review" in one of these windows by pressing NVDA+CTRL+t. At this point, we can read the content of the terminal (i.e. result of commands) with backward and forward buttons of braille display.
Now, go to the second instance. At this stage, we can't read the contents of this terminal. We are forced to reswitch in review mode By pressing 3 times on CTRL+NVDA+t to find the expected behavior.

LeonarddeR · 2017-12-08T11:44:22Z

That's a very nice catch there. This, among other similar bugs, should have been fixed in the branch now, and will be visible as soon as review and incubation has taken place.

…leReviewMove when tethered to focus

aaclause · 2017-12-12T16:21:31Z

I am running on next-14726,ebbd6f4c.
I still have bugs with scrolling in some cases (e.g. in Microsoft Word).

LeonarddeR · 2017-12-12T18:21:18Z

@Andre9642 commented on 12 dec. 2017 17:21 CET:

I am running on next-14726,ebbd6f4c.
I still have bugs with scrolling in some cases (e.g. in Microsoft Word).

Could you please provide steps to reproduce?

aaclause · 2017-12-14T11:31:20Z

Sorry for the delayed response.

Could you please provide steps to reproduce?

Unfortunately, it's complicated to reproduce and list all cases because sometimes I do not understand the steps that caused the problem...
However, I spotted a case where it happens every time.

Open Word, and choose "blank document".
Type the next content (it is a simple example):
```
111
222
333
```
Restart NVDA with NVDA+q (with add-ons disabled preferably). Normally, you should fall back on the document.
Go to the top of document (with Control+home). Now, we can read "111" on the braille display.
Try to scroll forward with your braille display.

Expected behavior: you should move on the next line and the braille display should shows "222".
Actual behavior: NVDA switch to review mode (braille cursor = dot 8), cursor has not moved and the braille display shows "111".

I reproduced this on several machines, Word 2016 and NVDA version next-14726,ebbd6f4c.

LeonarddeR · 2017-12-14T15:32:37Z

@Andre9642 commented on 14 dec. 2017 12:31 CET:

Open Word, and choose "blank document".
Type the next content (it is a simple example):
111
222
333
Restart NVDA with NVDA+q (with add-ons disabled preferably). Normally, you should fall back on the document.

Go to the top of document (with Control+home). Now, we can read "111" on the braille display.

Try to scroll forward with your braille display.
Expected behavior: you should move on the next line and the braille display should shows "222".

Actual behavior: NVDA switch to review mode (braille cursor = dot 8), cursor has not moved and the braille display shows "111".

For me, the result always is as expected. Could you do the following at a python console:
import config; print config.conf['braille']['tetherTo']

This parameter is reset to focus when explicitly thetering automatically, however when the tether setting has not been touched after an update and it was initially set to review, auto tethering is on and the config parameter is set to review, which should actually not be the case.
@michaeldcurran/@jcsteh: I think I yet prefer a config upgrade step for this as per the reason above. Furthermore, we can also convert tethering to an option based option in the config spec instead of a string based option. Thoughts? ANother reason is that using both a string based value and the autoTether boolean together feels quite ugly to me.

aaclause · 2017-12-14T16:23:29Z

>>> import config; print config.conf['braille']['tetherTo']
focus

I have another problem, I'm wondering if it's related: when I start/restart NVDA in a virtual document (eg: in Firefox, in a message in Thunderbird...), the browse mode is not enabled automatically. I am forced to leave and return to the virtual content.

LeonarddeR · 2017-12-14T16:26:16Z

Could you test the latter with NVDA master? also, what dissplay are you using and which commands to scroll? N.B. Sent on behalf of @BabbageCom

…

Op 14 dec. 2017 om 17:23 heeft André-Abush Clause ***@***.***> het volgende geschreven: >>> import config; print config.conf['braille']['tetherTo'] focus I have another problem, I'm wondering if it's related: when I start/restart NVDA in a virtual document (eg: in Firefox, in a message in Thunderbird...), the browse mode is not enabled automatically. I am forced to leave and return to the virtual content. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

LeonarddeR · 2017-12-14T20:10:13Z

@Andre9642: Also, just to make sure, do you have any configuration profiles active that might override the tethering setting? I've looked at the code again and, apart from what I mentioned in #7489 (comment) , I can't yet think of what might cause this behavior. The fact that I can't reproduce this makes it even more difficult to deal with it properly.

aaclause · 2017-12-14T20:45:13Z

@LeonarddeR I've just tested with the last master version. And... I have the same issue. I'm sorry, so this isn't related to this new feature!

LeonarddeR · 2017-12-15T04:52:08Z

@Andre9642 commented on 14 dec. 2017 21:45 CET:

@LeonarddeR I've just tested with the last master version. And... I have the same issue. I'm sorry, so this isn't related to this new feature!

Just to make sure, which issue are you now referring to? The browse mode issue or the scrolling issue in Word?

michaelDCurran · 2018-01-01T23:55:34Z

@LeonarddeR: Are you happy for this to be merged to master and closed? Also, can someone provide a what's new entry in the description?

LeonarddeR · 2018-01-02T07:42:27Z

@Andre9642: Could you please answer my last question? Are the issues you were experiencing related to auto tethering or not?
@derekriemer: What do you think of this? It seems you have found some instability, even though I wasn't able to reproduce.

aaclause · 2018-01-04T00:55:38Z

Are the issues you were experiencing related to auto tethering or not?

After all, no. I have the same problem with NVDA 2017.4 concerning the scrolling issue in Word.
The scroll forward issue is present especially when I scroll a lot of times in a complex document and, sometimes, when the cursor is located on the first character of the document. Tested with addons disabled. If I have more precise details, I'll create an issue.

Regarding the browse mode issue, I have some instability (very) occasionally and randomly (= hard to reproduce). I don't know if it's related to auto tethering. :/ When this happens, the Braille display no longer follows if I move with arrow keys. I couldn't get this issue with NVDA 2017.4.

LeonarddeR · 2018-01-05T06:27:45Z

@Andre9642 commented on 4 jan. 2018 01:55 CET:

Are the issues you were experiencing related to auto tethering or not?

After all, no. I have the same problem with NVDA 2017.4 concerning the scrolling issue in Word.
The scroll forward issue is present especially when I scroll a lot of times in a complex document and, sometimes, when the cursor is located on the first character of the document. Tested with addons disabled. If I have more precise details, I'll create an issue.

Regarding the browse mode issue, I have some instability (very) occasionally and randomly (= hard to reproduce). I don't know if it's related to auto tethering. :/ When this happens, the Braille display no longer follows if I move with arrow keys. I couldn't get this issue with NVDA 2017.4.

Thanks for the clarification. May be you could answer the following questions?

Do you, by any chance, know whether switching between browse mode and focus mode could cause this?
What is shown on the display when it does not follow?
Does the non-following start after interacting with the review cursor or object navigation, or just randomly?

LeonarddeR · 2018-01-09T14:49:11Z

@michaelDCurran commented on 2 jan. 2018 00:55 CET:

@LeonarddeR: Are you happy for this to be merged to master and closed? Also, can someone provide a what's new entry in the description?

I just added a what's new entry.

Add support for auto tethering to NVDA

33caa88

LeonarddeR added the component/braille label Aug 11, 2017

LeonarddeR requested review from dkager and michaelDCurran October 12, 2017 18:51

Merge remote-tracking branch 'origin/master' into i2385, fixing merge…

f1c59f9

… conflicts

dkager suggested changes Oct 13, 2017

View reviewed changes

Leonard de Ruijter added 5 commits October 14, 2017 09:51

Some review actions

3b20c56

Merge remote-tracking branch 'origin/master' into i2385

ab56024

Use extensionPoints.callWithSupportedKwargs as a fallback for executi…

c630521

…ng event handlers, to support executing events with undefined kwargs.

Pass an additional parameter for becomeNavigatorObject (isFocus)

e862e36

Some small comma fixes and default params are now correct

57491c1

LeonarddeR force-pushed the i2385 branch from 45d1332 to 57491c1 Compare October 14, 2017 09:21

dkager approved these changes Oct 14, 2017

View reviewed changes

Make sure caret moves properly update the braille display when it was…

60fc8da

… tethered to review before

michaelDCurran requested changes Nov 23, 2017

View reviewed changes

Leonard de Ruijter added 3 commits November 23, 2017 14:54

Merge remote-tracking branch 'origin/master' into i2385

a3839c4

First review actions

962d2dc

Some more logging in eventHandler

2bcff2e

More review actions regarding UX

7702a4e

michaelDCurran approved these changes Dec 4, 2017

View reviewed changes

fix braille_toFocus in such a way that it also goes back to focus whe…

5898a5e

…n reviewing a terminal

LeonarddeR mentioned this pull request Dec 6, 2017

Tethering braille to review and back to focus fails in browse mode #5237

Closed

Fix cases where tethering to review and back to focus in browse mode …

73aebb5

…would result in the caret not being followed correctly. This also applies to the braille_toFocus script

No longer handleGainFocus when tethered to review, and no longer hand…

2e29741

…leReviewMove when tethered to focus

LeonarddeR force-pushed the i2385 branch from db7c007 to 2e29741 Compare December 8, 2017 12:24

michaelDCurran approved these changes Dec 11, 2017

View reviewed changes

michaelDCurran added a commit that referenced this pull request Dec 11, 2017

Incubates #7489

54c36c5

michaelDCurran added a commit that referenced this pull request Dec 11, 2017

Incubates #7489

d116e5c

LeonarddeR mentioned this pull request Dec 13, 2017

Add automatic background braille display detection #7741

Merged

michaelDCurran merged commit 841ee00 into nvaccess:master Jan 15, 2018

nvaccessAuto removed the incubating label Jan 15, 2018

nvaccessAuto added this to the 2018.1 milestone Jan 15, 2018

LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019

Add the ability to automatically tether to focus or review #7489

Add the ability to automatically tether to focus or review #7489

Conversation

LeonarddeR commented Aug 11, 2017 • edited

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Changelog entry

dkager left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelDCurran left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeonarddeR commented Nov 23, 2017 • edited

michaelDCurran commented Nov 23, 2017 via email

josephsl commented Nov 23, 2017 via email

jcsteh commented Nov 23, 2017 via email

michaelDCurran commented Nov 23, 2017 via email

jcsteh commented Nov 23, 2017 via email

michaelDCurran commented Nov 24, 2017 via email

LeonarddeR commented Nov 24, 2017

bramd commented Nov 24, 2017

michaelDCurran commented Dec 4, 2017

LeonarddeR commented Dec 7, 2017 • edited

aaclause commented Dec 8, 2017 • edited

LeonarddeR commented Dec 8, 2017

aaclause commented Dec 12, 2017

LeonarddeR commented Dec 12, 2017

aaclause commented Dec 14, 2017 • edited

LeonarddeR commented Dec 14, 2017

aaclause commented Dec 14, 2017

LeonarddeR commented Dec 14, 2017 via email

LeonarddeR commented Dec 14, 2017

aaclause commented Dec 14, 2017

LeonarddeR commented Dec 15, 2017

michaelDCurran commented Jan 1, 2018

LeonarddeR commented Jan 2, 2018

aaclause commented Jan 4, 2018 • edited

LeonarddeR commented Jan 5, 2018

LeonarddeR commented Jan 9, 2018

LeonarddeR commented Aug 11, 2017 •

edited

LeonarddeR commented Nov 23, 2017 •

edited

LeonarddeR commented Dec 7, 2017 •

edited

aaclause commented Dec 8, 2017 •

edited

aaclause commented Dec 14, 2017 •

edited

aaclause commented Jan 4, 2018 •

edited