Update brailleNote driver to use hwIo and thus make it thread safe. #7581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7574.
Summary of the issue:
From #7574 (comment):
Description of how this pull request fixes the issue:
Updates the driver to use
hwIo.Serial
.Testing performed:
I don't have a BrailleNote, so couldn't test this. However, @josephsl confirmed in #7574 (comment) that it works for him.
Known issues with pull request:
None known.
Change log entry:
Not user visible at this stage, so no change log entry. However, this can safely be merged before braille display detection. It should provide a slight performance improvement when there are lots of writes and should mean we aren't waking our main thread as often due to continual polling.