Docs17.4 #7662

josephsl · 2017-10-15T17:52:02Z

Link to issue number:

None

Summary of the issue:

Documentation updates and edits.

Description of how this pull request fixes the issue:

Added Macedonian as a supported language, edits to what's new document and user guide, edited URL's displayed on user guide to point to newer websites (in case of developer guide) and use HTTPS (Add-ons website).

Testing performed:

None

Known issues with pull request:

None

Change log entry:

None

* WDAG: clarified which version of Windows 10 introduced it (Fall Creators Update). * espeak-ng: shortened commit hash to eight characters. * Addons -> add-ons. * Portable copy command line: remove 'support for' to make the entry consistent. * Braille dispaly key assignment: punctuation change.

…s for developer Guide and extra voices wiki page.

josephsl · 2017-10-15T17:52:38Z

If no objections are raised, I recommend merging this into master before translatable string freeze. Thanks,

ThomasStivers · 2017-10-15T18:10:03Z

user_docs/en/userGuide.t2t


 ++ Reload plugins ++
 This item, once activated, reloads app modules and global plugins without restarting NVDA, which can be useful for developers.

 + Supported Speech Synthesizers +[SupportedSpeechSynths]
 This section contains information about the speech synthesizers supported by NVDA.
-For an even more extensive list of  free and commercial synthesizers that you can purchase and download for use with NVDA, please see the page at [http://www.nvda-project.org/wiki/ExtraVoices http://www.nvda-project.org/wiki/ExtraVoices].
+For an even more extensive list of  free and commercial synthesizers that you can purchase and download for use with NVDA, please see [extra voices page https://github.com/nvaccess/nvda/wiki/ExtraVoices].


Perhaps "see the extra voices page" instead of "see extra voices page".

josephsl · 2017-10-15T18:11:45Z

Hi, @derekriemer, any issues with grammar in this commit?

derekriemer

Have you checked for any other references to nvda-project.org, community.*?

derekriemer · 2017-10-15T18:16:57Z

user_docs/en/changes.t2t

- Version information for addons is now reported when being updated. (#5324)
- Added support for new command line parameters to create a portable copy of NVDA. (#6329)
- Support for Microsoft Edge running within Windows Defender Application Guard (#7600)
+- Version information for add-ons is now reported when being updated. (#5324)


derekriemer · 2017-10-15T18:19:08Z

user_docs/en/changes.t2t

- Added support for new command line parameters to create a portable copy of NVDA. (#6329)
- Support for Microsoft Edge running within Windows Defender Application Guard (#7600)
+- Version information for add-ons is now reported when being updated. (#5324)
+- Added new command line parameters to create a portable copy of NVDA. (#6329)


what did you change here?

derekriemer · 2017-10-15T18:19:50Z

user_docs/en/changes.t2t

- Support for Microsoft Edge running within Windows Defender Application Guard (#7600)
+- Version information for add-ons is now reported when being updated. (#5324)
+- Added new command line parameters to create a portable copy of NVDA. (#6329)
+- Support for Microsoft Edge running within Windows Defender Application Guard in Windows 10 Fall Creators Update. (#7600)


(and above)?

derekriemer · 2017-10-15T18:20:46Z

user_docs/en/changes.t2t

 - If running on a laptop or tablet, NVDA will now report when a charger is connected/disconnected, and when the screen orientation changes. (#4574, #4612)
+- New language: Macedonian.


I'd say this more flowery. Like
NVDA has now been translated into Macedonian!

not going to make it flowery?

derekriemer · 2017-10-15T18:23:35Z

user_docs/en/changes.t2t

 - Web dialogs in Firefox and Chrome web browsers now automatically use browse Mode, unless inside of a web application. (#4493)
 - In browse mode, tabbing and moving with quick navigation commands no longer announces jumping out of containers such as lists and tables, which makes navigating more efficient. (#2591)
 - In Browse mode for Firefox and Chrome, the name of form field groups are now announced when moving into them with quick navigation or when tabbing. (#3321)
 - In browse mode, the quick navigation command for embedded objects (o and shift+o) now includes audio and video elements as well as elements with the aria roles application and dialog. (#7239)
- Espeak-ng has been updated (to commit 01919cd48a566cdf34347784b2e74554b376e900), this resolves some issues with producing release builds. (#7385)
+- Espeak-ng has been updated to commit 01919cd4, which resolves some issues with producing release builds. (#7385)


Arguably, () around the commit stuff was more correct since it lets the non-essential info be in parenthesis. However, the way you did this is more compact. If noone else objects, I think this is better. Maybe a comma before to could make it slightly more obvious the commit info is extra, but it really doesn't matter.

derekriemer · 2017-10-15T18:24:29Z

user_docs/en/changes.t2t

@@ -34,7 +35,7 @@ What's New in NVDA
 - NVDA no longer becomes noticeably slower when many tabs are open in either Firefox or Chrome web browsers. (#3138)
 - Cursor routing for the MDV Lilli Braille display no longer incorrectly moves one braille cell ahead of where it should be. (#7469)
 - In Internet Explorer and other MSHTML documents, the HTML5 required attribute is now supported to indicate the required state of a form field. (#7321)
- Braille displays are now updated when typing Arabic characters in a left-aligned WordPad document (#511).
+- Braille displays are now updated when typing Arabic characters in a left-aligned WordPad document. (#511)


Nice catch.

derekriemer · 2017-10-15T18:27:54Z

user_docs/en/userGuide.t2t


 ++ Reload plugins ++
 This item, once activated, reloads app modules and global plugins without restarting NVDA, which can be useful for developers.

 + Supported Speech Synthesizers +[SupportedSpeechSynths]
 This section contains information about the speech synthesizers supported by NVDA.
-For an even more extensive list of  free and commercial synthesizers that you can purchase and download for use with NVDA, please see the page at [http://www.nvda-project.org/wiki/ExtraVoices http://www.nvda-project.org/wiki/ExtraVoices].
+For an even more extensive list of  free and commercial synthesizers that you can purchase and download for use with NVDA, please see [extra voices page https://github.com/nvaccess/nvda/wiki/ExtraVoices].


josephsl · 2017-10-15T18:30:36Z

Hi, ah yes, thanks for reminding me about that. Will do that as part of a more general source code cleanup. Thanks.

michaelDCurran · 2017-11-01T06:36:24Z

where is this up to? translation freeze really needs to be tomorrow if possible.

# Conflicts: # user_docs/en/changes.t2t

josephsl · 2017-11-01T06:46:23Z

Hi, ready to go. I think you should be the one writing highlight text for 2017.4. Thanks. From: Michael Curran [mailto:notifications@github.com] Sent: Tuesday, October 31, 2017 11:36 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com> Subject: Re: [nvaccess/nvda] Docs17.4 (#7662) where is this up to? translation freeze really needs to be tomorrow if possible. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7662 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkM_A1ZVUOoumNMEO0o4765vayQC_ks5syBFpgaJpZM4P51EY> .

michaelDCurran · 2017-11-01T06:49:15Z

Yep, I'll right the highlight paragraph. Thanks

derekriemer

You updated espeak from master it looks like. Please make sure you don't cause an espeak regression in master before the freeze.

derekriemer · 2017-11-01T11:23:03Z

user_docs/en/changes.t2t

 - If running on a laptop or tablet, NVDA will now report when a charger is connected/disconnected, and when the screen orientation changes. (#4574, #4612)
+- New language: Macedonian.


not going to make it flowery?

derekriemer · 2017-11-01T11:23:49Z

user_docs/en/changes.t2t

@@ -25,13 +26,13 @@ What's New in NVDA
 - In browse mode, tabbing and moving with quick navigation commands no longer announces jumping out of containers such as lists and tables, which makes navigating more efficient. (#2591)
 - In Browse mode for Firefox and Chrome, the name of form field groups are now announced when moving into them with quick navigation or when tabbing. (#3321)
 - In browse mode, the quick navigation command for embedded objects (o and shift+o) now includes audio and video elements as well as elements with the aria roles application and dialog. (#7239)
- Espeak-ng has been updated to commit 01919cd4, which resolves some issues with producing release builds. (#7385)
+- Espeak-ng has been updated (to release 1.49.2), this resolves some issues with producing release builds. (#7385, #7583)
 - On the third activation of the 'read status bar' command, it's contents is copied to the clipboard. (#1785)


please fix it's to its

michaelDCurran

include/espeak has been incorrectly changed.

michaelDCurran

I corrected the eSpeak submodule commit back to eSpeak 1.49.2

josephsl · 2017-11-02T02:47:05Z

Hi, thanks (too many merges from master perhaps…). From: Michael Curran [mailto:notifications@github.com] Sent: Wednesday, November 1, 2017 7:29 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com> Subject: Re: [nvaccess/nvda] Docs17.4 (#7662) @michaelDCurran approved this pull request. I corrected the eSpeak submodule commit back to eSpeak 1.49.2 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7662 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkNRqpY1sYHthXRr0HV6VyRIsneUmks5sySj0gaJpZM4P51EY> .

josephsl added 4 commits October 15, 2017 10:32

New language: Macedonian.

ab73f86

MathPlayer documentation URL encased in t2t link markup for consistency.

53485fd

User guide: change http to https for add-ons website, change addresse…

2a81da3

…s for developer Guide and extra voices wiki page.

ThomasStivers reviewed Oct 15, 2017

View reviewed changes

derekriemer suggested changes Oct 15, 2017

View reviewed changes

josephsl added 2 commits October 31, 2017 23:42

Merge branch 'master' into docs17.4

a667d5d

# Conflicts: # user_docs/en/changes.t2t

Final notes

032ae17

derekriemer reviewed Nov 1, 2017

View reviewed changes

josephsl added 3 commits November 1, 2017 07:10

What's new: linguistic fixes.

1b90a28

Merge branch 'master' into docs17.4

c881237

What's new: capitalization

c03717d

michaelDCurran requested changes Nov 1, 2017

View reviewed changes

josephsl and others added 2 commits November 1, 2017 16:01

Merge branch 'master' into docs17.4

da28581

Switch eSpeak back to 1.49.2 (NVDA master)

92b5822

michaelDCurran approved these changes Nov 2, 2017

View reviewed changes

michaelDCurran merged commit 868bbe5 into nvaccess:master Nov 2, 2017

nvaccessAuto added this to the 2017.4 milestone Nov 2, 2017

This was referenced Nov 3, 2017

Possibly Remove the UI Automation only supported in Windows 7 and later Statement from the User Guide #7664

Closed

In UserGuide change links which point to community.nvda-project.org/ to appropriate sites #7500

Closed

josephsl deleted the docs17.4 branch September 16, 2019 02:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs17.4 #7662

Docs17.4 #7662

josephsl commented Oct 15, 2017

josephsl commented Oct 15, 2017

ThomasStivers Oct 15, 2017

derekriemer Oct 15, 2017

josephsl commented Oct 15, 2017 via email •

edited by feerrenrut

derekriemer left a comment

derekriemer Oct 15, 2017

derekriemer Oct 15, 2017

derekriemer Oct 15, 2017

derekriemer Oct 15, 2017

derekriemer Nov 1, 2017

derekriemer Oct 15, 2017

derekriemer Oct 15, 2017

derekriemer Oct 15, 2017

josephsl commented Oct 15, 2017 via email •

edited by feerrenrut

michaelDCurran commented Nov 1, 2017

josephsl commented Nov 1, 2017 via email

michaelDCurran commented Nov 1, 2017 via email

derekriemer left a comment

derekriemer Nov 1, 2017

derekriemer Nov 1, 2017

michaelDCurran left a comment

michaelDCurran left a comment

josephsl commented Nov 2, 2017 via email

		- If running on a laptop or tablet, NVDA will now report when a charger is connected/disconnected, and when the screen orientation changes. (#4574, #4612)
		- New language: Macedonian.

Docs17.4 #7662

Docs17.4 #7662

Conversation

josephsl commented Oct 15, 2017

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

josephsl commented Oct 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josephsl commented Oct 15, 2017 via email • edited by feerrenrut

derekriemer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josephsl commented Oct 15, 2017 via email • edited by feerrenrut

michaelDCurran commented Nov 1, 2017

josephsl commented Nov 1, 2017 via email

michaelDCurran commented Nov 1, 2017 via email

derekriemer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelDCurran left a comment

Choose a reason for hiding this comment

michaelDCurran left a comment

Choose a reason for hiding this comment

josephsl commented Nov 2, 2017 via email

josephsl commented Oct 15, 2017 via email •

edited by feerrenrut

josephsl commented Oct 15, 2017 via email •

edited by feerrenrut