Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config profile switches also reflect a different tether setting #7919

Merged
merged 1 commit into from Jan 18, 2018

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None, regression caused by #2385

Summary of the issue:

Since auto tethering is implemented, we are using a _tether property on the braille handler to reflect the internal tethering state, since it can be changed by auto tethering without changing the state in the configuration. However, it seems I/we missed the fact that this internal state should be updated properly as soon as one switches a config profile. If not, which is the current situation, the following will occur.

  1. Set NVDA to be manually tethered to focus
  2. Create a new config profile that is manually tethered to review
  3. Switch profiles
  4. When you switch to the review profile, NVDA will still be tethered to focus.

Description of how this pull request fixes the issue:

Sets the internal _tether property according to the configuration on every profile switch.

Testing performed:

@dkager tested the case as described above. I will give auto tethering a test in an hour or two, but expect no issues with that, as the state of tethering is handled by the auto tethering mechanism anyway.

Known issues with pull request:

None

Change log entry:

None

Copy link
Collaborator

@dkager dkager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming there is no property on the handler to indicate if auto-tethering is enabled or not? I.e. we don't need to get that from config as well?

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Jan 18, 2018 via email

@michaelDCurran michaelDCurran merged commit e6292ba into nvaccess:master Jan 18, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Jan 18, 2018
@LeonarddeR LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BabbageWork Pull requests filed on behalf of Babbage B.V. bug/regression component/braille quick fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants