Make config profile switches also reflect a different tether setting #7919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, regression caused by #2385
Summary of the issue:
Since auto tethering is implemented, we are using a _tether property on the braille handler to reflect the internal tethering state, since it can be changed by auto tethering without changing the state in the configuration. However, it seems I/we missed the fact that this internal state should be updated properly as soon as one switches a config profile. If not, which is the current situation, the following will occur.
Description of how this pull request fixes the issue:
Sets the internal _tether property according to the configuration on every profile switch.
Testing performed:
@dkager tested the case as described above. I will give auto tethering a test in an hour or two, but expect no issues with that, as the state of tethering is handled by the auto tethering mechanism anyway.
Known issues with pull request:
None
Change log entry:
None