Add additional vid and pid to the ALVA driver to support the protocol converter #8047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on the rc branch and should possibly be merged there for RC2.
Link to issue number:
Closes #6731 once again.
Summary of the issue:
@Adriani90 reported in #1586 that the Converter Card isn't working as expected.
The ALVA protocol reports PID 0x0699 for the protocol converter. However, according to the source of BRLTTY, the PID is 0x0600.
Description of how this pull request fixes the issue:
I added PID 0x0600 to the driver while leaving 0x0699 around, since we aren't sure whether the 0x0699 PID is false or meant for newer iterations of the converter.
Testing performed:
None. As @Adriani90 reported this issue, it would be appreciated much if he or someone else could test this try build.
Known issues with pull request:
We should at some point remove the erroneous PID. Braille display auto detection (#1271) might be a good moment for this.
Change log entry:
Changes since RC1