Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional vid and pid to the ALVA driver to support the protocol converter #8047

Closed
wants to merge 1 commit into from

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Feb 28, 2018

This pr is based on the rc branch and should possibly be merged there for RC2.

Link to issue number:

Closes #6731 once again.

Summary of the issue:

@Adriani90 reported in #1586 that the Converter Card isn't working as expected.

The ALVA protocol reports PID 0x0699 for the protocol converter. However, according to the source of BRLTTY, the PID is 0x0600.

Description of how this pull request fixes the issue:

I added PID 0x0600 to the driver while leaving 0x0699 around, since we aren't sure whether the 0x0699 PID is false or meant for newer iterations of the converter.

Testing performed:

None. As @Adriani90 reported this issue, it would be appreciated much if he or someone else could test this try build.

Known issues with pull request:

We should at some point remove the erroneous PID. Braille display auto detection (#1271) might be a good moment for this.

Change log entry:

Changes since RC1

Copy link
Member

@michaelDCurran michaelDCurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I shall merge to rc once we get confirmation this works.

@LeonarddeR
Copy link
Collaborator Author

Logs by @Adriani90 reveal that 0x0699 is the right pID. Closing this, as it is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants