Explorer: do not announce 'unknown' when opening quick link menu and selecting items from it (Windows+X) #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows+X). Re nvaccess#8137. Windows with the class name of LauncherTipWnd and ApplicationManager_DesktopShellWindow fires focus events, causing NVDA to announce 'unknown' when opening quick link menu (Windows+X) and selecting an item from this menu. Suppress this if possible.
LeonarddeR
approved these changes
Apr 5, 2018
source/appModules/explorer.py
Outdated
| @@ -267,10 +267,11 @@ def event_gainFocus(self, obj, nextHandler): | |||
| # Therefore, if there is a pending focus event, don't bother handling this event. | |||
| return | |||
|
|
|||
| if wClass == "ForegroundStaging": | |||
| if wClass in ("ForegroundStaging", "LauncherTipWnd", "ApplicationManager_DesktopShellWindow"): | |||
| # #5116: The Windows 10 Task View fires foreground/focus on this weird invisible window before and after it appears. | |||
There was a problem hiding this comment.
"This weird invisible window" needs clarification now. Please change this line to mention ForegroundStaging",
|
Hi, ah yes, will do today. Thanks.
From: Leonard de Ruijter <notifications@github.com>
Sent: Thursday, April 5, 2018 10:46 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Explorer: do not announce 'unknown' when opening quick link menu and selecting items from it (Windows+X) (#8138)
@LeonarddeR approved this pull request.
_____
In source/appModules/explorer.py <#8138 (comment)> :
@@ -267,10 +267,11 @@ def event_gainFocus(self, obj, nextHandler):
# Therefore, if there is a pending focus event, don't bother handling this event.
return
- if wClass == "ForegroundStaging":
+ if wClass in ("ForegroundStaging", "LauncherTipWnd", "ApplicationManager_DesktopShellWindow"):
# #5116: The Windows 10 Task View fires foreground/focus on this weird invisible window before and after it appears.
"This weird invisible window" needs clarification now. Please change this line to mention ForegroundStaging",
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8138 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkBaUiclpp5kTpweUCQY7Pbc-eXNYks5tllhggaJpZM4TDGhb> .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8137
Summary of the issue:
Do not announce "unknown" when opening quick link menu and selecting items in there (Windows+X).
Description of how this pull request fixes the issue:
Windows with the class name of LauncherTipWnd and ApplicationManager_DesktopShellWindow fires focus events, causing NVDA to announce 'unknown' when opening quick link menu (Windows+X) and selecting an item from this menu. Suppress this if possible.
Testing performed:
Tested on version 1803 and earlier builds.
Known issues with pull request:
None
Change log entry:
Bug fixes: On Windows 8 and later, NVDA will no longer announce "unknown" when opening quick link menu )Windows+X) and selecting items from this menu. (#8137)