Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IA2_ROLE_BLOCK_QUOTE. #8577

Merged
merged 4 commits into from Jul 31, 2018
Merged

Support IA2_ROLE_BLOCK_QUOTE. #8577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c9d861
Support IA2_ROLE_BLOCK_QUOTE.
jcsteh Jul 31, 2018
7b99b7f
Merge branch 'master' into HEAD
michaelDCurran Jul 31, 2018
4a6da8e
Update what's new
michaelDCurran Jul 31, 2018
5cc2e2e
Gecko_ia2 virtualBuffer: support jumping to ARIA blockquotes with qui…
michaelDCurran Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions source/IAccessibleHandler.py
View file
Open in desktop
Expand Up @@ -254,6 +254,7 @@ def flushEvents(self):
IA2_ROLE_VIEW_PORT:controlTypes.ROLE_VIEWPORT,
IA2_ROLE_CONTENT_DELETION:controlTypes.ROLE_DELETED_CONTENT,
IA2_ROLE_CONTENT_INSERTION:controlTypes.ROLE_INSERTED_CONTENT,
IA2_ROLE_BLOCK_QUOTE:controlTypes.ROLE_BLOCKQUOTE,
#some common string roles
"frame":controlTypes.ROLE_FRAME,
"iframe":controlTypes.ROLE_INTERNALFRAME,
Expand Down
7 changes: 6 additions & 1 deletion source/virtualBuffers/gecko_ia2.py
View file
Open in desktop
Expand Up @@ -269,7 +269,12 @@ def _searchableAttribsForNodeType(self,nodeType):
elif nodeType=="graphic":
attrs={"IAccessible::role":[oleacc.ROLE_SYSTEM_GRAPHIC]}
elif nodeType=="blockQuote":
attrs={"IAccessible2::attribute_tag":self._searchableTagValues(["blockquote"])}
attrs=[
# Search for a tag of blockquote for older implementations before the blockquote IAccessible2 role existed.
{"IAccessible2::attribute_tag":self._searchableTagValues(["blockquote"])},
# Also support the new blockquote IAccessible2 role
{"IAccessible::role":[IAccessibleHandler.IA2_ROLE_BLOCK_QUOTE]},
]
elif nodeType=="focusable":
attrs={"IAccessible::state_%s"%oleacc.STATE_SYSTEM_FOCUSABLE:[1]}
elif nodeType=="landmark":
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@ What's New in NVDA
- You can enable this feature by selecting the automatic option from the list of braille displays in NVDA's braille display selection dialog.
- Please consult the documentation for additional details.
- Added support for various modern input features introduced in recent Windows 10 releases. These include emoji panel (Fall Creators Update), dictation (Fall Creators Update), hardware keyboard input suggestions (April 2018 Update), and cloud clipboard (RS5). (#7273)
- Content marked as a block quote using ARIA (role blockquote) is now supported in Mozilla Firefox 63. (#8577)


== Changes ==
Expand Down