Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_uri accept all valid schemas #481

Merged
merged 1 commit into from
May 24, 2023
Merged

Make is_uri accept all valid schemas #481

merged 1 commit into from
May 24, 2023

Conversation

sassanh
Copy link
Contributor

@sassanh sassanh commented Apr 17, 2023

A URI scheme can contain "-", "+" and "*" as well as digits and letters.

https://www.rfc-editor.org/rfc/rfc3986#page-17

@sassanh
Copy link
Contributor Author

sassanh commented May 23, 2023

@tjdevries Sorry to ping you, it's a very small PR if you have the time to check.

@sassanh
Copy link
Contributor Author

sassanh commented May 23, 2023

Some context: it is needed because oil.nvim uses oil+ssh:// schema for files editing over ssh and they don't work properly with telescope.nvim because telescope is using plenary to "clean" filenames and plenary doesn't detect oil+ssh as a URI schema.

A URI scheme can contain "-", "+" and "*" as well as digits and letters.

https://www.rfc-editor.org/rfc/rfc3986#page-17
@Conni2461
Copy link
Collaborator

sorry i overlooked that PR. Thanks :)

I had to manually rebase, because github doesnt let me trigger a CI :(

image

@Conni2461 Conni2461 merged commit e31cf81 into nvim-lua:master May 24, 2023
5 checks passed
@sassanh
Copy link
Contributor Author

sassanh commented May 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants