A + in a URL is sometimes decoded as a space

[Fil]

This affects at least one user who reported that their site hosted on S3 was broken. dist/_npm/d3@7.9.0/+esm.js was 403, but dist/_npm/d3@7.9.0/%2Besm.js was 200.

We could (must) url-encode the src. But, it's going to look ugly… maybe we can find a better way. (Also we should make sure that we url-encode everything that needs to be encoded.)

[mbostock]

Maybe a simple thing we could do here is -esm.js or _esm.js instead of +esm.js? The purpose of + is to avoid a conflict with some other file in that package, but I don’t think in practice that we’d ever see a -esm.js or _esm.js either. .esm.js could also work (but maybe is undesirable since it would hide the file).

Another possibility is dist/_npm/d3@7.9.0.js but I think this would be harder to implement since we currently use the directory dist/_npm/d3@7.9.0 to check for already-resolved versions.

[Fil]

I'll try that. It will also clarify the code (+esm will be the source, and -esm will be our copy).

[mbostock]

Oops, sorry I already started… 😬

[mbostock]

We should probably still URL-encode such links as needed… that’s a bug and _esm.js is just a workaround?

[Fil]

Yes we must urlencode the link and it's nicer to use an underscore (#1056) because the urlencoded + is "ugly".

[Fil]

not planning to urlencode everything for now—it's too messy