apply encodeURI to imports

[Fil]

closes #1055

[Fil]

this is a welcome change

[mbostock]

This doesn’t help with #1055 because encodeURI doesn’t escape + because it “may part of the URI syntax.” 😅

encodeURI("/_npm/d3@7.9.0/+esm.js") // "/_npm/d3@7.9.0/+esm.js"

encodeURIComponent does encode the +, but then it also encodes slashes, so it’s not what we want either.

encodeURI("/_npm/d3@7.9.0/+esm.js") // "%2F_npm%2Fd3%407.9.0%2F%2Besm.js"

I don’t actually know what the right solution is here. I think we should investigate whether other people have run into similar issues with S3; this might be an S3-specific problem.

[mbostock]

This suggests that it’s an S3-specific bug. So we could specifically accommodate + in the file name if we wanted to, but we’d have to parse the URL and only rewrite + in the file name (not the query!).

https://stackoverflow.com/questions/38282932/amazon-s3-url-being-encoded-to-2

Maybe we do nothing and just avoid this bug in S3?

[mbostock]

Also, there are lots of other places where we render src and href attributes that might need this type of escaping, right? Like everything that gets passed through normalizeLink and all the asset attributes in rewriteHtml? I don’t know how we could do this universally.

[Fil]

Apparently linkedom and jsdom don't care about this either:

import {parseHTML} from "linkedom";
const {document} = parseHTML("<a>");
document.querySelector("a").setAttribute("href", "a b+c\"d'e$f#g&h");
console.log(`${document}`); // <a href="a b+c&quot;d'e$f#g&h"></a>

const document2 = await import("jsdom").then(({JSDOM}) => new JSDOM("").window.document);
const a = document2.createElement("a");
a.setAttribute("href", "a b+c\"d'e$f#g&h");
console.log(`${a.outerHTML}`); // <a href="a b+c&quot;d'e$f#g&amp;h"></a>

so yeah, let's just be careful. There are a few other characters that won't work, like : for file names, emojis (#783 ), long filenames on some OS… I don't think we can fix all of that.