Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize page path="/" to "/index" #1022

Merged
merged 1 commit into from Mar 12, 2024
Merged

normalize page path="/" to "/index" #1022

merged 1 commit into from Mar 12, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 8, 2024

normalize the pages config option so that "/" is the same as "/index"

closes #689

@Fil Fil requested a review from mbostock March 8, 2024 14:33
@Fil

This comment was marked as outdated.

@Fil Fil marked this pull request as draft March 10, 2024 15:08
@Fil Fil mentioned this pull request Mar 11, 2024
@Fil Fil closed this Mar 12, 2024
@Fil Fil reopened this Mar 12, 2024
@Fil
Copy link
Contributor Author

Fil commented Mar 12, 2024

PTAL

@Fil Fil marked this pull request as ready for review March 12, 2024 10:29
@Fil Fil enabled auto-merge (squash) March 12, 2024 10:30
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? It seems a bit strange to use a different form of normalization here (rather than using the same normalizeLink we use elsewhere), but okay.

@Fil Fil merged commit 336a949 into main Mar 12, 2024
8 checks passed
@Fil Fil deleted the fil/pager-0 branch March 12, 2024 13:09
Fil added a commit that referenced this pull request Mar 12, 2024
@Fil
Copy link
Contributor Author

Fil commented Mar 12, 2024

I tried that, but this normalization is removing search and hash — it's not about the "same URL" but about the "same page". Tests in #1045

Fil added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pager appears when there’s only one page in pages
2 participants