New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accept bare URL definitions for sql tables #1098
Conversation
--- sql: adresses: https://static.data.gouv.fr/resources/bureaux-de-vote-et-adresses-de-leurs-electeurs/20230626-135723/table-adresses-reu.parquet quakes: https://earthquake.usgs.gov/earthquakes/feed/v1.0/summary/all_day.csv --- ```sql echo SELECT COUNT() FROM quakes; ``` closes #1071
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is the right place to do this — normally we only call resolveFile on things that we know are files (unlike resolveImport, I guess). Look for calls to isAssetPath, which we should also use here. I’ll take a look and see if we can consolidate. Good find on the fix!
The caller is renderFiles Line 96 in efd8ba0
called where we build the Line 66 in efd8ba0
|
Yeah, we don’t want to declare a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to using the FROM-first syntax, e.g.,
CREATE TABLE 'quakes' AS FROM 'https://earthquake.usgs.gov/earthquakes/feed/v1.0/summary/all_day.csv';
etc.
closes #1071
I believe this is more a bugfix than a new feature (we previously returned
/https:/static.data.gouv.fr/resources/burea……….parquet
).