show GitHub stars in header #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mbostock
commented
Mar 22, 2024
mbostock
commented
Fil
reviewed
Mar 22, 2024
observablehq.config.ts
Outdated
| @@ -1,3 +1,7 @@ | |||
| import {formatPrefix} from "d3-format"; | |||
|
|
|||
| const {stargazers_count} = await github("/repos/observablehq/framework").catch(() => ({stargazers_count: 4242})); | |||
There was a problem hiding this comment.
nit: I'd default to null or undefined if the github API call fails. This might require an additional test below to avoid showing 0.0k/NaNk stars (although it could be ok too to show NaN if we can't get the information).
There was a problem hiding this comment.
I was only thinking of local development. In CI I’d want the deploy to fail if we’re not able to talk to GitHub, so that we always show the correct star count. I’ve changed the code to rethrow in CI.
Fil
approved these changes
Mar 22, 2024
|
We may want some caching if we load the config lazily on each request… #695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.