Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log a confirmation message after a successful logout #1131

Merged
merged 2 commits into from Mar 23, 2024
Merged

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 23, 2024

No description provided.

@Fil Fil requested a review from mbostock March 23, 2024 16:25
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are strict about what gets logged, but otherwise LGTM!

@Fil Fil merged commit 3982706 into main Mar 23, 2024
4 checks passed
@Fil Fil deleted the fil/logout-msg branch March 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants