Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two pass render #765

Closed
wants to merge 7 commits into from
Closed

two pass render #765

wants to merge 7 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Feb 13, 2024

this builds on top of #702 (memoization of the parsing function) and the first few commits of #758 (the two-pass rendering of the hash files PR).

the first part (memoization) helps speed up (re)indexation (#543), lazy config (#695) reload; the second part (two-pass rendering) is necessary to make last-modified (#699) work reliably and to do content-hashes (#758).

@Fil Fil requested a review from mbostock February 13, 2024 11:00
This was referenced Feb 13, 2024
@Fil Fil mentioned this pull request Feb 13, 2024
11 tasks
@Fil
Copy link
Contributor Author

Fil commented Feb 28, 2024

this will probably need to be revamped after #843

@Fil Fil marked this pull request as draft February 28, 2024 09:56
@Fil
Copy link
Contributor Author

Fil commented Feb 28, 2024

for instance 5fbcad8 is fixed in #843

@Fil Fil closed this Mar 15, 2024
@Fil Fil deleted the fil/two-pass-render branch March 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant