add a test case that checks for pep8 compliance #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- among other things, this will make it easy to spot pep8 pollution in pull requests before merging - currently won't work because it depends on changes in matplotlib (see matplotlib/matplotlib#2486), have to wait and see how that turns out
|
+1 I like this! I added an optional dependency on pep8 to the setup.py. We could also integrate a full flake8 check in the test suite. |
krischer
added a commit
that referenced
this pull request
Oct 2, 2013
add a test case that checks for pep8 compliance
megies
added a commit
that referenced
this pull request
Oct 2, 2013
- add pep8 to debian package recommends - install newest matplotlib in travis - skip pep8 test if matplotlib is < 1.4 - add more test dependencies to extra_requires in setup.py
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull requests before merging
(see make pep8 test routine reusable for other projects matplotlib/matplotlib#2486), have to wait and see how that turns
out
See http://tests.obspy.org/9690/#1 for a test example of the current master.
I also want to find out untracked files and exclude them if git is available via a system call. But I'll wait if the idea gets accepted in matplotlib, because I'll do it there then.