Active Cards #43
Active Cards #43
Conversation
This also handles the condition where a card was created from a list item, therefore it has no actions.
Adding timecop in there just to be sure. I think it's possible the builder that the spec is using was not correctly adding / subtracting days. I believe they're all speaking about the same date types as well.
The lists property in time-tracker.js was always a function called like lists() b/c of the specs. I've converted this to lazily evaluate this.subject so you can modify the lists prior to calling this.subject and it still works.
Apparently if an exception happens in a success handler in jQuery, the AJAX request will never be marked as completed. Because of this, the cukes were hanging because it always looked like there was outstanding AJAX.
|
I'm seeing some pretty weird results for several of my boards. For instance, here's one with a ton of cards in active:
Here's one where we mostly think about big-ticket items, but move some cards more frenquently:
And this one says there is no data to display, despite the fact that I clearly have a card in the "Doing" column:
|
|
The first one I've seen when there are a ton of cards (I think you have 20 there) which is why I truncated to 50 characters in the label; not sure what I should do with that, or if the label for the column needs to be displayed differently so it can fit the data? For me, truncating to the 50 characters fixed when we had ~12 in flight, but I can lessen it to see if that helps? For the 2nd one I'm not sure what's being pointed out; am I missing something with what's wrong? For the 3rd one I'd have to see the data. I can see that the "Work In Progress" list shows there's 1 in doing, can you verify it's non-archived and in that list? I've definitely not see anything like that happen. |
|
1st image: Certainly something needs to be done. Maybe the answer is some form of pagination? Another possibility is to make the box fit the content as the content height expands beyond the default height, but I worry this would look quite ugly. 2nd image: Mostly a point of reference, though I'll note that I'm not in love with the way the labels are showing up mostly vertically. Would it be possible to only show the card name for the currently "highlighted" column, where "highlighted" means rolled over with a mouse? 3rd image: There is definitely a card in the Doing column in that board, where the only actions which have ever been performed on it were [Create in ToDo, Move to Doing]. The card is well over 1 year old - does that have any affect on your logic? |
|
For the first two issues I've removed the labels from the I was additionally able to reproduce the other issue where older cards are not displaying. I have yet to look into it, but I will report back 👍 |
|
Sorry for the delay on this one - did some unexpected traveling last week and then my computer went jank yesterday. SOON. |
|
Definitely looks a lot better in the case of having a ton of cards in progress. One weird thing is there are some columns with 0s and they can't be hovered over. What does it mean when a card has 0? That it was added today? If that's the case, it might be a good idea to "round up" to 1 day for cards with 0 so they don't show up empty.
|
|
I can get behind that; I will round them up in the report. Thanks for the reminder that I need to look into the other issue (where older cards are not showing up). Would that be the last thing then on this PR? |
|
Functionality-wise it should be; the code looks fine on first glance but I'll probably take another look at it once we're all working. You'll also want to rebase on sep/master to get some updates I pushed recently (upgraded to ruby 2.3.1 - sorry in advance for that). |
## DescriptionThis PR adds an "Active Cards" list that shows cards that are currently being worked (between Start / End of work) and a stacked-column graph on how many days they've spent in each list in between.
The days are only including business days (vs. accounting for total days). Potentially I could see adding the "Total Days" to the overlay if it was deemed important.