Vunit dependencies #384
Merged
Vunit dependencies #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added fields to edatool File class - "core": name of the core which included the src file - added core dependency and core file map to vunit jinja env - "core_dependencies": mapping of core name to core name of dependencies - "core_files": mapping of core name to src file objects - reworked vunit template - save return value of added files added to libraries - generate mapping of core names to vunit file objects - specify core dependencies as dependencies between core files
nopeslide
force-pushed
the
vunit_dependencies
branch
from
b13b5da
to
8110da8
Compare
|
Checked it against multiple of my projects and it looks good, |
|
Getting back to this took a fair bit longer than I had hoped for, but it looks fine now. Thank you for your contributions. Picked and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mitigated the problem of #358 by adding a few checks if the fields are present.
Will have to do further testing with an actual codebase, but I think this should do it.
fixes #350