[BUGS#1248,1251] add regression test and refactor FindMatches class #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
changed the title
miurahr
force-pushed
the
topic/miurahr/matches/fix-separate-segmented
branch
from
bc9c2cd
to
e42b6d3
Compare
miurahr
changed the title
|
❌ Run Gradle test failed: |
2 similar comments
|
❌ Run Gradle test failed: |
|
❌ Run Gradle test failed: |
- Add FindMatchesThreadTest to reproduce BUGS#1248 - Add a test case to test FindMatches with the case of BUGS#1248. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/matches/fix-separate-segmented
branch
from
9da1a14
to
bc92bea
Compare
- Split FindMatches#search method to searchNormal and searchSegmented, and remove boolean allowSeparateSegmentMatch argument from constructor. - Refactor FindMatchesThread#search to call searchNormal then searchSegmented if necessary. searchSEgmented method skips external TMs. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/matches/fix-separate-segmented
branch
from
bc92bea
to
4665a8e
Compare
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
A topic branch here waiting a realization of GUI behavior acceptance test #964 is accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please mark github LABEL of the type of change your PR introduces:
Which ticket is resolved?
tm/penalty-nnn value is not respected
https://sourceforge.net/p/omegat/bugs/1248/
FindMatcher always search separate segment match without penalty
https://sourceforge.net/p/omegat/bugs/1251/
What does this PR change?
FindMatchesandFindMatchesThreadclasses, that is failed by the bug reported.FindMatches#searchmethod tosearchNormalandsearchSegmented, and removeboolean allowSeparateSegmentMatchargument from constructor.FindMatchesThread#searchto callsearchNormalthensearchSegmentedif necessary.searchSEgmentedmethod skips external TMs.Other information