reafactor: use AbstractMnemonicsAction to define Menu handlers #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- refactor exit actions menus Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/gui/main/menu-construct-with-properties-abstract-action
branch
from
d0ed739
to
e4248fe
Compare
|
rebased on current master. |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/gui/main/menu-construct-with-properties-abstract-action
branch
from
cb48713
to
80bf094
Compare
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
Now ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
refactor
Which ticket is resolved?
dev-ML https://sourceforge.net/p/omegat/mailman/message/58749145/
What does this PR change?
MainWindowMenuHandler#braBrabrahActionperformedmethod withActionclasses that extends withAbstractMnemonicActionclassOther information
Implementation depends on lib-mnemonics enhancement
omegat-org/lib-mnemonics#8