targetclid.sock: change SocketMode to 0600 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocketMode= If listening on a file system socket or FIFO, this option specifies the file system access mode used when creating the file node. Takes an access mode in octal notation. Defaults to 0666. Thanks Alex Murray[@alexmurray], for reporting. Fixes: open-iscsi#162 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
lxbsz
approved these changes
Mar 30, 2020
|
@alexmurray @maurizio-lombardi this should go in master and I think given #165 is also fixed now, we are all set for a new release tag 👍 |
|
@iammattcoleman Noted, let me also do an another round of test with some fresh VM's, I will keep you posted. Thanks for ringing the bell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketMode=
If listening on a file system socket or FIFO, this option specifies the
file system access mode used when creating the file node. Takes an
access mode in octal notation. Defaults to 0666.
Thanks Alex Murray[@alexmurray], for reporting.
Fixes: #162
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com