[Improvement] Update SubnetValLoop
#465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoyang07
reviewed
Mar 7, 2023
|
Fix lint. |
twmht
force-pushed
the
fix_nas
branch
2 times, most recently
from
88bbb69
to
266de9f
Compare
gaoyang07
approved these changes
Mar 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #465 +/- ##
===========================================
+ Coverage 79.32% 79.49% +0.17%
===========================================
Files 280 280
Lines 14096 14094 -2
Branches 2155 2156 +1
===========================================
+ Hits 11181 11204 +23
+ Misses 2452 2422 -30
- Partials 463 468 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
twmht
force-pushed
the
fix_nas
branch
2 times, most recently
from
77a59a9
to
f4cdfe5
Compare
|
The failed test seems not related to this PR? |
gaoyang07
changed the title
SubnetValLoop
1.Fix set_max_subnet or set_min_subnet not found exception 2 Add the fleibility to define custom subnet kinds 3.Support to specifiy None with ResorceEstimator Signed-off-by: Ming-Hsuan-Tu <qrnnis2623891@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
set_max_subnetorset_min_subnetwas not found in dev-1.x, so we need to have a fix for that.and also we need to have the feature to define what kind of subnet we want to evaluate.
In addition, we can specify None to resource estimator since its typing is Optional.
Modification
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: