Skip to content

Commit

Permalink
Disable DQS polarity workaround.
Browse files Browse the repository at this point in the history
Workaround is currently disabled, we will need to remove it completely
if the lab decides this is the permanent fix.

Change-Id: I6c93c3609df9bfcbc0fd48948c392bb805eaea4b
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35404
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: BRIANA E. FOXWORTH <befoxwor@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Dev-Ready: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35421
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
aamarin authored and dcrowell77 committed Jan 30, 2017
1 parent 4719c9c commit 19f6e06
Showing 1 changed file with 5 additions and 0 deletions.
Expand Up @@ -159,6 +159,9 @@ fapi_try_exit:
template< fapi2::TargetType T >
inline bool chip_ec_feature_mss_dqs_polarity(const fapi2::Target<T>& i_target)
{
// Seeing better results with Monza and LaGrange by switching this off
// TODO RTC:168029 - Remove DQS polarity EC feature if turning it off is a permanent fix.
#ifdef DO_POLARITY_WORKAROUND
const auto l_chip = mss::find_target<fapi2::TARGET_TYPE_PROC_CHIP>(i_target);
uint8_t l_value = 0;

Expand All @@ -170,6 +173,8 @@ fapi_try_exit:
FAPI_ERR("failed accessing ATTR_CHIP_EC_FEATURE_MSS_DQS_POLARITY: 0x%lx (target: %s)",
uint64_t(fapi2::current_err), mss::c_str(i_target));
fapi2::Assert(false);
#endif

return false;
}

Expand Down

0 comments on commit 19f6e06

Please sign in to comment.