Skip to content

Commit

Permalink
Change MCBIST 1R work around to actually check the pause bits
Browse files Browse the repository at this point in the history
Change-Id: If74067133ab901ab08860a26f7dc234a2c351c79
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34986
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Dev-Ready: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34995
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
brs332 authored and dcrowell77 committed Jan 24, 2017
1 parent faac790 commit 2508661
Showing 1 changed file with 9 additions and 2 deletions.
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016 */
/* Contributors Listed Below - COPYRIGHT 2016,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -123,7 +123,14 @@ fapi2::ReturnCode end_of_rank( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target
return FAPI2_RC_SUCCESS;
}

if( ! io_program.iv_config.getBit<TT::MCBIST_CFG_PAUSE_AFTER_RANK>() )
// Keep in mind that pause-on-error-mode is two bits and it doesn't encode master/slave. The
// end_boundary enums are constructed such that STOP_AFTER_MASTER_RANK is really stop on
// either master or slave for the purposes of this field. So, checking stop-after-master-rank
// will catch both master and slave pauses which is correct for this work-around.
uint64_t l_pause_mode = 0;
io_program.iv_config.extractToRight<TT::CFG_PAUSE_ON_ERROR_MODE, TT::CFG_PAUSE_ON_ERROR_MODE_LEN>(l_pause_mode);

if( l_pause_mode != mss::mcbist::end_boundary::STOP_AFTER_MASTER_RANK )
{
FAPI_INF("not checking rank boundaries on this MCBIST (%s), we're ok", mss::c_str(i_target));
return FAPI2_RC_SUCCESS;
Expand Down

0 comments on commit 2508661

Please sign in to comment.