Skip to content

Commit

Permalink
Remove phantom MCS/MCA functional targets in single socket
Browse files Browse the repository at this point in the history
  - Current DVPD design relies on presence detect on MCS
    However this has the side effect of marking them present
    and functional.  This commit is a hack to fix that
    till the DVPD design can be addressed

Change-Id: I1290423934f1f39021d80bd3fe98d6ad66217734
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36500
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
sannerd authored and dcrowell77 committed Feb 17, 2017
1 parent 005bc0c commit 2ed0c04
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions src/usr/hwas/hwasPlat.C
Expand Up @@ -518,6 +518,20 @@ errlHndl_t platPresenceDetect(TargetHandleList &io_targets)
present = false;
}

// if TYPE_MCS
// Need to handle "special" -- DVPD cache relies on this
// being called for pnor cache management, however this causes
// spurious MCS's to be marked present/functional when they are
// trully tied to processor PG. So remove from list since
// the DVPD present detect hook has been called
// TODO RTC 169572 -- Fix correctly by reworking DVPD
if (pTarget->getAttr<ATTR_TYPE>() == TYPE_MCS)
{
// erase this target, and 'increment' to next
pTarget_it = io_targets.erase(pTarget_it);
continue;
}

if (present == true)
{
HWAS_DBG( "pTarget %.8X - detected present",
Expand Down

0 comments on commit 2ed0c04

Please sign in to comment.