Skip to content

Commit

Permalink
Modify raw_card infras. to take in general raw card revs
Browse files Browse the repository at this point in the history
Added rcd01 namespace to prevent possible future clashes with rcd02.
Moved raw_card data structure from RDIMM to common since this will
used by all dimm modules.
Added fake LRDIMM RCD settings to move forward, added a TODO to
figure what RCD settings we want...

Change-Id: Ifea2ed2fce1cae9dcfa0a9705d541b1d76b5a5e6
Original-Change-Id: I849c3bd6b988247d652e34c4c50569d6a28c343b
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29895
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37406
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
aamarin authored and dcrowell77 committed Mar 3, 2017
1 parent 89233fa commit a6be506
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -43,7 +43,7 @@
// mss lib
#include <lib/spd/spd_factory.H>
#include <lib/spd/common/spd_decoder.H>
#include <lib/spd/rdimm/raw_cards.H>
#include <lib/spd/common/raw_cards.H>
#include <lib/utils/checker.H>
#include <lib/utils/c_str.H>
#include <lib/utils/conversions.H>
Expand Down Expand Up @@ -445,7 +445,7 @@ fapi2::ReturnCode factory(const fapi2::Target<TARGET_TYPE_DIMM>& i_target,
uint8_t l_encoding_rev = 0;
uint8_t l_additions_rev = 0;
uint8_t l_ref_raw_card_rev = 0;
raw_card_t l_raw_card;
rcd01::raw_card_t l_raw_card;

// Attribute setting needed by mss::c_str() which is used in
// the SPD decoder for debugging help
Expand All @@ -462,7 +462,7 @@ fapi2::ReturnCode factory(const fapi2::Target<TARGET_TYPE_DIMM>& i_target,
// raw card settings
FAPI_TRY( reference_raw_card(i_target, i_spd_data, l_ref_raw_card_rev) );

if( !find_value_from_key(RDIMM_RAW_CARDS, l_ref_raw_card_rev, l_raw_card) )
if( !find_value_from_key( rcd01::RAW_CARDS, l_ref_raw_card_rev, l_raw_card) )
{
FAPI_ERR( "Invalid reference raw card recieved: %d", l_ref_raw_card_rev );
return fapi2::FAPI2_RC_FALSE;
Expand Down

0 comments on commit a6be506

Please sign in to comment.